Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7394

TFS Web Access URLs are incorrectly generated for TFS 2008

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: tfs-plugin
    • Labels:
      None
    • Environment:
      Any
    • Similar Issues:

      Description

      All URLs for links to changesets in TFS Web Access on TFS 2008 are incorrectly generated like this:
      http://TFSMachine:8080/UI/Pages/Scc/cs.aspx?cs=12345
      instead of like this:
      http://TFSMachine:8080/UI/Pages/Scc/ViewChangeset.aspx?changeset=12345

      The current version of the plugin (v1.11) concatenates a base URL inferred from the "Example URL to change set page" configuration for a given job, with the string "cs.aspx?cs=" and finally with the changeset id.

      This behavior is not correct for TFS 2008 because the URL probably changed since TFS 2005 and the string "cs.aspx?cs=" is now "ViewChangeset.aspx?changeset=".

      Instead of just upgrading the string "cs.aspx?cs=", I recommend changing a little the behavior and the configuration options of the plugin to use the example URL as a template where the user must type a placeholder for the changeset id. Assuming the placeholder is CHANGESET_ID_PLACEHOLDER then the user should specify the URL like this:
      http://TFSMachine:8080/UI/Pages/Scc/ViewChangeset.aspx?changeset=CHANGESET_ID_PLACEHOLDER

      Other users experienced this problem, as seen here: http://wiki.jenkins-ci.org/display/JENKINS/Team+Foundation+Server+Plugin?focusedCommentId=44302694#comment-44302694

        Attachments

          Activity

          Hide
          jeffolson jeffolson added a comment -

          Thank you, Erik!

          Show
          jeffolson jeffolson added a comment - Thank you, Erik!
          Hide
          redsolo redsolo added a comment -

          Can you two please verify that the browser links works as they should in the latest version?

          Show
          redsolo redsolo added a comment - Can you two please verify that the browser links works as they should in the latest version?
          Hide
          bogdaniosif bogdaniosif added a comment -

          My Hudson instance doesn't yet see v1.17 available for upgrade.

          Show
          bogdaniosif bogdaniosif added a comment - My Hudson instance doesn't yet see v1.17 available for upgrade.
          Hide
          bogdaniosif bogdaniosif added a comment -

          I upgraded to v1.17 and it works as expected for me. I used simply "http://TswaSrv:TswaPort" for "Team System Web Access URL". Thanks redsolo.

          P.S: In ~6 months we managed to figure out that what we need is to change the help text. Duh, winning

          Show
          bogdaniosif bogdaniosif added a comment - I upgraded to v1.17 and it works as expected for me. I used simply "http://TswaSrv:TswaPort" for "Team System Web Access URL". Thanks redsolo. P.S: In ~6 months we managed to figure out that what we need is to change the help text. Duh, winning
          Hide
          jeffolson jeffolson added a comment -

          Looks good here as well. Thanks again!

          Show
          jeffolson jeffolson added a comment - Looks good here as well. Thanks again!

            People

            • Assignee:
              redsolo redsolo
              Reporter:
              bogdaniosif bogdaniosif
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: