-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: git-plugin
-
Labels:None
-
Similar Issues:
Background;
My windows %HOME% directory is on a network share. git is using an ssh key from this folder to locate the server. Running a hudson slave logged in as the same user doesn't have access this directory so requires a custom environment variable to specify a different folder.
Setting a slave specific HOME environment variable works fine for running the build, but this variable is not used when polling for changes.
Just want to note that this is not fixed currently with 1.1 and around 8 months later.
This is also important if you're specifying environmental variables such as GIT_SSH to point to a special SSH wrapper. The clone works fine but polling doesn't pick up this environmental variable so it can never tell if the repository changed.
Also: setting the tool location on the slave via environment variables is not considered during polling.
Steps to reproduce using Jenking Git Plugin 1.3.0 on Jenkins 1.510:
Set environment variable on master:
PATH_TO_TOOLS=c:\somewhere\tools
On the Slave:
PATH_TO_TOOLS=d:\elsewhere\tools
Tool-Location for default git installation: ${PATH_TO_TOOLS}/git/git.exe
During polling, jenkins always tries to execute git.exe in c:\somewhere\tools, although it is run on the slave
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
src/main/java/hudson/plugins/git/GitSCM.java
src/test/java/hudson/plugins/git/GitSCMTest.java
http://jenkins-ci.org/commit/git-plugin/c5b127f98ebc652eead68b39aa7f1c93094cbcc4
Log:
[FIXED JENKINS-7411]
Environment variables are in fact not used at all during expansions.
This commit fixes that. As discussed in the ticket, and as done
elsewhere, the standard convention is to use previous build's
environment to expand polling.
Also see JENKINS-19042
Closing the issue since the commit which fixed it was submitted over 6 months ago.
No, it's not resolved in 1.1. The behaviour has changed, but is not correct.