Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7838

Would be nice to have a different quote set for each build result (stable/unstable/failed)

    Details

    • Similar Issues:

      Description

      The current plugin has quotes that are shown for any type of build.
      It would be nice if we could define a different set of quotes for stable/unstable/failed builds.

      <persona id='djb' displayName='Daniel J. Bernstein'>
      <quote>This is a generic quote that may be used for any builds for backwards compatability</quote>
      <quote type="stable">This is only for stable builds.</quote>
      <quote type="unstable">This is only for unstable builds.</quote>
      <quote type="failed">This is only for failed builds.</quote>
      ...
      </persona>

      That way we can have the CEO saying "You're fired" only for failed builds.

        Attachments

        1. persona.hpi
          24 kB
        2. persona.jar
          22 kB
        3. persona.zip
          21 kB

          Activity

          Hide
          whren whren added a comment -

          Find a quick try of attempt for your improvement request : 1.2-SNAPSHOT modified
          jar, hpi and source provided
          It simply follows the actual logic of images, meaning quotes for 'success', 'failure', 'other'.
          So with your example persona :

          <persona id='djb' displayName='Daniel J. Bernstein'>
          <quote>This is a generic quote that may be used for any builds for backwards compatability</quote>
          <quote type="success">This is only for stable builds.</quote>
          <quote type="failure">This is only for failed builds.</quote>
          <quote type="other">This is only for unstable builds.</quote>
          ...
          </persona>

          As you suggested simple quote (<quote>) are kept for backwards compatibility.
          Note that if type is not one of 'success', 'failure', 'other' (case insensitive) the quote will be added as a simple quote (<quote>).

          Show
          whren whren added a comment - Find a quick try of attempt for your improvement request : 1.2-SNAPSHOT modified jar, hpi and source provided It simply follows the actual logic of images, meaning quotes for 'success', 'failure', 'other'. So with your example persona : <persona id='djb' displayName='Daniel J. Bernstein'> <quote>This is a generic quote that may be used for any builds for backwards compatability</quote> <quote type="success">This is only for stable builds.</quote> <quote type="failure">This is only for failed builds.</quote> <quote type="other">This is only for unstable builds.</quote> ... </persona> As you suggested simple quote (<quote>) are kept for backwards compatibility. Note that if type is not one of 'success', 'failure', 'other' (case insensitive) the quote will be added as a simple quote (<quote>).
          Show
          sogabe sogabe added a comment - - edited applied the patch. thanks. https://github.com/jenkinsci/persona-plugin/commit/ab57b8b3a750bf51b6a5c4f3843a21878f02bc79

            People

            • Assignee:
              sogabe sogabe
              Reporter:
              teilo James Nord
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: