Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8276

Add View Job Filters to the List View Section

    Details

    • Similar Issues:

      Description

      The attached patch will enhance the List View Section to provide View Job Filters the way List View does. I have tested it locally to see that it works, but it needs a more careful review.

        Attachments

          Activity

          Hide
          tbingaman Timothy Bingaman added a comment -

          cool, thanks a lot for the patch, and sorry it's taken me so long to look at this.

          I'm just making a couple tweaks (pulling it up into the top level SectionedViewSection class so that all the different sections can use the filters), then I'll commit it.

          Show
          tbingaman Timothy Bingaman added a comment - cool, thanks a lot for the patch, and sorry it's taken me so long to look at this. I'm just making a couple tweaks (pulling it up into the top level SectionedViewSection class so that all the different sections can use the filters), then I'll commit it.
          Hide
          tbingaman Timothy Bingaman added a comment - - edited

          applied and released in version 1.13

          Show
          tbingaman Timothy Bingaman added a comment - - edited applied and released in version 1.13
          Hide
          mrasscha Michel Rasschaert added a comment -

          Using Jenkins LTS 1.480.3, there is no way to add View Job filters to the List view section.

          Show
          mrasscha Michel Rasschaert added a comment - Using Jenkins LTS 1.480.3, there is no way to add View Job filters to the List view section.
          Hide
          mrasscha Michel Rasschaert added a comment -

          Ok. It seems to be working after all but the Job Filters dropdown does not appear when creating the list view section. You must first create the list view section, save the sectioned view and edit it.

          Show
          mrasscha Michel Rasschaert added a comment - Ok. It seems to be working after all but the Job Filters dropdown does not appear when creating the list view section. You must first create the list view section, save the sectioned view and edit it.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Richard Thomas
          Path:
          src/main/java/hudson/plugins/sectioned_view/SectionedViewSection.java
          src/main/java/hudson/plugins/sectioned_view/SectionedViewSectionDescriptor.java
          src/main/resources/hudson/plugins/sectioned_view/ListViewSection/config.jelly
          src/main/resources/hudson/plugins/sectioned_view/SectionedViewSection/config.jelly
          http://jenkins-ci.org/commit/sectioned-view-plugin/7a9f98fd328d2bb60ed3b088eafdd38138d99a4c
          Log:
          JENKINS-8276 Moved method that tests for job filter extenstions from SectionedViewSection to SectionedViewSectionDescriptor.

          The config.jelly file was previously attempting to invoke this method in SectionedViewSection via the 'instance'
          reference. However the 'instance' does not exist until the new section is saved. Because of this the
          'Add Job Filter' button could never appear until after the view was saved and re-opened for editing.

          By moving the method to the SectionedViewSectionDescriptor class it is available before the section is created by the first save.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Richard Thomas Path: src/main/java/hudson/plugins/sectioned_view/SectionedViewSection.java src/main/java/hudson/plugins/sectioned_view/SectionedViewSectionDescriptor.java src/main/resources/hudson/plugins/sectioned_view/ListViewSection/config.jelly src/main/resources/hudson/plugins/sectioned_view/SectionedViewSection/config.jelly http://jenkins-ci.org/commit/sectioned-view-plugin/7a9f98fd328d2bb60ed3b088eafdd38138d99a4c Log: JENKINS-8276 Moved method that tests for job filter extenstions from SectionedViewSection to SectionedViewSectionDescriptor. The config.jelly file was previously attempting to invoke this method in SectionedViewSection via the 'instance' reference. However the 'instance' does not exist until the new section is saved. Because of this the 'Add Job Filter' button could never appear until after the view was saved and re-opened for editing. By moving the method to the SectionedViewSectionDescriptor class it is available before the section is created by the first save.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Timothy Bingaman
          Path:
          src/main/java/hudson/plugins/sectioned_view/SectionedViewSection.java
          src/main/java/hudson/plugins/sectioned_view/SectionedViewSectionDescriptor.java
          src/main/resources/hudson/plugins/sectioned_view/ListViewSection/config.jelly
          src/main/resources/hudson/plugins/sectioned_view/SectionedViewSection/config.jelly
          http://jenkins-ci.org/commit/sectioned-view-plugin/7e82f2774b5d93f9078078623e0a965ecdb73818
          Log:
          Merge pull request #11 from opencloud/JENKINS-8276-fix-job-filters

          JENKINS-8276 Moved method that tests for job filter extenstions fro…

          Compare: https://github.com/jenkinsci/sectioned-view-plugin/compare/376973723327...7e82f2774b5d

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Timothy Bingaman Path: src/main/java/hudson/plugins/sectioned_view/SectionedViewSection.java src/main/java/hudson/plugins/sectioned_view/SectionedViewSectionDescriptor.java src/main/resources/hudson/plugins/sectioned_view/ListViewSection/config.jelly src/main/resources/hudson/plugins/sectioned_view/SectionedViewSection/config.jelly http://jenkins-ci.org/commit/sectioned-view-plugin/7e82f2774b5d93f9078078623e0a965ecdb73818 Log: Merge pull request #11 from opencloud/ JENKINS-8276 -fix-job-filters JENKINS-8276 Moved method that tests for job filter extenstions fro… Compare: https://github.com/jenkinsci/sectioned-view-plugin/compare/376973723327...7e82f2774b5d
          Hide
          tbingaman Timothy Bingaman added a comment -

          Fix will be released in version 1.20

          Show
          tbingaman Timothy Bingaman added a comment - Fix will be released in version 1.20

            People

            • Assignee:
              tbingaman Timothy Bingaman
              Reporter:
              jacob_robertson Jacob Robertson
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: