Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8438

Node names can be edited to include slashes and then cannot be removed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None

      Description

      Using Hudson v1.392, I did the following:

      • Created a node with a valid name (e.g., "Key Manager Build")
      • Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")

      I am now unable to edit or delete this node.

        Activity

        jrh3k5 jrh3k5 created issue -
        sogabe sogabe made changes -
        Field Original Value New Value
        Assignee sogabe [ sogabe ]
        sogabe sogabe made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in hudson
        User: Seiji Sogabe
        Path:
        changelog.html
        core/src/main/java/hudson/slaves/NodeDescriptor.java
        core/src/main/resources/hudson/slaves/Messages.properties
        core/src/main/resources/hudson/slaves/Messages_ja.properties
        http://hudson-labs.org/commit/core/46f2f02f9dbea085e67ff70673f38644b14b4f01
        Log:
        [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/slaves/NodeDescriptor.java core/src/main/resources/hudson/slaves/Messages.properties core/src/main/resources/hudson/slaves/Messages_ja.properties http://hudson-labs.org/commit/core/46f2f02f9dbea085e67ff70673f38644b14b4f01 Log: [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.
        scm_issue_link SCM/JIRA link daemon made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        jrh3k5 jrh3k5 added a comment -

        Just out of curiosity, is there anything, short of editing the underlying XML, that would allow me to fix the node name?

        Show
        jrh3k5 jrh3k5 added a comment - Just out of curiosity, is there anything, short of editing the underlying XML, that would allow me to fix the node name?
        Hide
        sogabe sogabe added a comment -

        Edit your config.xml as follows and restart Hudson instance.

        <hudson>
        :
        <slaves>
        <slave>
        <name>Win7</name> // <-- Change this to correct name.
        <description>Windows 7</description>
        <remoteFS>/tmp</remoteFS>
        <numExecutors>1</numExecutors>
        <mode>NORMAL</mode>
        <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
        :

        Show
        sogabe sogabe added a comment - Edit your config.xml as follows and restart Hudson instance. <hudson> : <slaves> <slave> <name>Win7</name> // <-- Change this to correct name. <description>Windows 7</description> <remoteFS>/tmp</remoteFS> <numExecutors>1</numExecutors> <mode>NORMAL</mode> <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/> :
        Hide
        jrh3k5 jrh3k5 added a comment -

        Awesome, thanks!

        Show
        jrh3k5 jrh3k5 added a comment - Awesome, thanks!
        Hide
        dogfood dogfood added a comment -

        Integrated in hudson_main_trunk #450
        [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

        Seiji Sogabe :
        Files :

        • core/src/main/resources/hudson/slaves/Messages.properties
        • core/src/main/java/hudson/slaves/NodeDescriptor.java
        • core/src/main/resources/hudson/slaves/Messages_ja.properties
        • changelog.html
        Show
        dogfood dogfood added a comment - Integrated in hudson_main_trunk #450 [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed. Seiji Sogabe : Files : core/src/main/resources/hudson/slaves/Messages.properties core/src/main/java/hudson/slaves/NodeDescriptor.java core/src/main/resources/hudson/slaves/Messages_ja.properties changelog.html
        sogabe sogabe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            sogabe sogabe
            Reporter:
            jrh3k5 jrh3k5
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: