Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8642

Defaults for unstable, still unstable, failing and still failing are a bit harsh :-)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Let's say, everybody might break a build once in a while. Now, I as someone on the recipient list would be more interested if the one breaking the build is not able to fix this. So I would suggest to send failing and unstable to the committers only and only in the case of repetition to include the recipient list.

      Regards
      Mirko

        Attachments

          Activity

          Hide
          fct fct added a comment -

          Do you mean that the admin should have the ability to set a default behavior based on build status in the Jenkins system configuration?

          Just like the default subject/content, a default recipient list can be configured as well as default behavior for each trigger, right?

          Show
          fct fct added a comment - Do you mean that the admin should have the ability to set a default behavior based on build status in the Jenkins system configuration? Just like the default subject/content, a default recipient list can be configured as well as default behavior for each trigger, right?
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Well, configurable defaults would be even better of course. Right now I only plee for less harsh defaults.

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Well, configurable defaults would be even better of course. Right now I only plee for less harsh defaults.
          Hide
          slide_o_mix Alex Earl added a comment -

          I wonder if people are too used to the current defaults. I would like some input as to whether people think this should be changed. It's a very easy change for these two triggers.

          Show
          slide_o_mix Alex Earl added a comment - I wonder if people are too used to the current defaults. I would like some input as to whether people think this should be changed. It's a very easy change for these two triggers.
          Hide
          slide_o_mix Alex Earl added a comment -

          This is currently actually the opposite of what you request. The failing (and unstable) trigger will send to the list + committers, and then the "still failing" and "still unstable" will only send to the committers. What say ye?

          Show
          slide_o_mix Alex Earl added a comment - This is currently actually the opposite of what you request. The failing (and unstable) trigger will send to the list + committers, and then the "still failing" and "still unstable" will only send to the committers. What say ye?
          Hide
          mfriedenhagen Mirko Friedenhagen added a comment -

          Hello Alex, maybe to rephrase my use case:
          Given developers A and B are members in a team of a project with slow development (only few commits) and both are on the recipient list.

          When B pushes a commit which fails
          then I expect B to receive a mail immediately but A should not receive this to give B the chance to fix this without bothering A.

          When however B does not fix the build and a daily build is triggered
          and the build still fails
          then I expect A and B to receive a mail as B might be on vacation, e.g.

          Show
          mfriedenhagen Mirko Friedenhagen added a comment - Hello Alex, maybe to rephrase my use case: Given developers A and B are members in a team of a project with slow development (only few commits) and both are on the recipient list. When B pushes a commit which fails then I expect B to receive a mail immediately but A should not receive this to give B the chance to fix this without bothering A. When however B does not fix the build and a daily build is triggered and the build still fails then I expect A and B to receive a mail as B might be on vacation, e.g.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java
          src/main/java/hudson/plugins/emailext/plugins/trigger/UnstableTrigger.java
          http://jenkins-ci.org/commit/email-ext-plugin/e46a5402955de00f4fa937599fd36f10670c82ed
          Log:
          Fix JENKINS-8642

          Changed defaults for the Failing, Still Failing, Unstable and Still Unstable triggers.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillFailingTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/StillUnstableTrigger.java src/main/java/hudson/plugins/emailext/plugins/trigger/UnstableTrigger.java http://jenkins-ci.org/commit/email-ext-plugin/e46a5402955de00f4fa937599fd36f10670c82ed Log: Fix JENKINS-8642 Changed defaults for the Failing, Still Failing, Unstable and Still Unstable triggers. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          slide_o_mix Alex Earl added a comment -

          Changed the default settings.

          Show
          slide_o_mix Alex Earl added a comment - Changed the default settings.

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              mfriedenhagen Mirko Friedenhagen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: