Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8676

Windows XP slave stopped working in 1.396 (related to name change)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: remoting
    • Labels:
      None

      Description

      See https://groups.google.com/d/topic/jenkinsci-dev/h3K8KbLvwKQ/discussion for discussion

      It appears that some code hasn't been properly in ManagedWindowsServiceLauncher.java

        Activity

        Hide
        lacostej lacostej added a comment -

        I have made a tentative fix here: https://github.com/lacostej/jenkins/commit/2332b114a38b6e62a8f28b40d4374b9e1d353de5

        Comments appreciated.

        Show
        lacostej lacostej added a comment - I have made a tentative fix here: https://github.com/lacostej/jenkins/commit/2332b114a38b6e62a8f28b40d4374b9e1d353de5 Comments appreciated.
        Hide
        axelheider Axel Heider added a comment -

        Same Problem here (Windows Master, Windows Slave)

        Connecting to xxx
        Checking if Java exists
        java full version "1.6.0_22-b04"
        Installing the Jenkins slave service
        Copying jenkins-slave.exe

        An then nothing happens. On the Windows Slave no files arrive.

        Show
        axelheider Axel Heider added a comment - Same Problem here (Windows Master, Windows Slave) Connecting to xxx Checking if Java exists java full version "1.6.0_22-b04" Installing the Jenkins slave service Copying jenkins-slave.exe An then nothing happens. On the Windows Slave no files arrive.
        Hide
        lacostej lacostej added a comment -

        Axel, if you want, I have a private build you might want to try (I still have to test the disconection and shutdown of the service part).

        Please also answer the following questions:

        • what is the name of the service on your windows slave (before and after upgrade) and after shutdown of the slaves

        http://coffeebreaks.org/software/jenkins/jenkins-1.397-lacostej-master-2332b114a38b6e62a8f28b40d4374b9e1d353de5.war

        MD5 7a9fe72d2b526457c3e9715e2123a4e8

        (Contains a few other fixes as well. See https://github.com/lacostej/jenkins/ for details.)

        Let me know how it goes !

        Show
        lacostej lacostej added a comment - Axel, if you want, I have a private build you might want to try (I still have to test the disconection and shutdown of the service part). Please also answer the following questions: what is the name of the service on your windows slave (before and after upgrade) and after shutdown of the slaves http://coffeebreaks.org/software/jenkins/jenkins-1.397-lacostej-master-2332b114a38b6e62a8f28b40d4374b9e1d353de5.war MD5 7a9fe72d2b526457c3e9715e2123a4e8 (Contains a few other fixes as well. See https://github.com/lacostej/jenkins/ for details.) Let me know how it goes !
        Hide
        axelheider Axel Heider added a comment - - edited

        I've cleaned up the Windows slave and deleted the old Husdon service. The name was

        Hudson Service at [Drive]:\[Path]\[Path]...
        

        Furthermore I've uninstalled the Hudson service on the Windows Master and installed a jenkins Service via the GUI. Now I want to cleanyl set up a Jenkons slave machine.

        I will test your new war.

        Show
        axelheider Axel Heider added a comment - - edited I've cleaned up the Windows slave and deleted the old Husdon service. The name was Hudson Service at [Drive]:\[Path]\[Path]... Furthermore I've uninstalled the Hudson service on the Windows Master and installed a jenkins Service via the GUI. Now I want to cleanyl set up a Jenkons slave machine. I will test your new war.
        Hide
        axelheider Axel Heider added a comment - - edited

        You build appears to work fine. The Windows slave is back online again and busily building.
        Thanks very much.

        Show
        axelheider Axel Heider added a comment - - edited You build appears to work fine. The Windows slave is back online again and busily building. Thanks very much.
        Hide
        pablaasmo Per Arnold Blaasmo added a comment -

        I works for windows XP for me also. So I guess this issue can be marked as resolved.

        I still have some problems with WIndows 7 64-bit with some access denied, but that is another issue (4929 I think).
        I though it was solved in release 1.387 "* Install as a service" now supports Vista and Windows 7. " but apparently not for 64-bit.

        Show
        pablaasmo Per Arnold Blaasmo added a comment - I works for windows XP for me also. So I guess this issue can be marked as resolved. I still have some problems with WIndows 7 64-bit with some access denied, but that is another issue (4929 I think). I though it was solved in release 1.387 "* Install as a service" now supports Vista and Windows 7. " but apparently not for 64-bit.
        Hide
        lacostej lacostej added a comment -

        OK let me cleanup the patch and I will submit it. Thanks for your help

        Show
        lacostej lacostej added a comment - OK let me cleanup the patch and I will submit it. Thanks for your help
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Jerome Lacoste
        Path:
        core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
        http://jenkins-ci.org/commit/core/f40b4ffbc8e33e2624bcee9e5ced5c10f25d5426
        Log:
        JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

        After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered.
        And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jerome Lacoste Path: core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java http://jenkins-ci.org/commit/core/f40b4ffbc8e33e2624bcee9e5ced5c10f25d5426 Log: JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change) After thinking about it, I don't want to deal with hudsonslave here. jenkinsslave should be found anyway, so that code path should not have been triggered. And cleaning up residual services isn't jenkins job. Otherwise both can't coexist.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Jerome Lacoste
        Path:
        core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java
        http://jenkins-ci.org/commit/core/2332b114a38b6e62a8f28b40d4374b9e1d353de5
        Log:
        JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change)

        The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe.

        Tentative fix, completely untested (no windows box around).
        Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jerome Lacoste Path: core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java http://jenkins-ci.org/commit/core/2332b114a38b6e62a8f28b40d4374b9e1d353de5 Log: JENKINS-8676 Windows XP slave stopped working in 1.396 (related to name change) The ManagedWindowsServiceLauncher refers to hudson.exe and hudson-slave.exe while we renamed the artifact to jenkins.exe. Tentative fix, completely untested (no windows box around). Not sure about the service name (jenkinsslave). I added a second check for backward compatibility but I have no idea if it's useful.

          People

          • Assignee:
            Unassigned
            Reporter:
            lacostej lacostej
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: