Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8853

don't try to include all of history when previous commit no longer exists

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
      None

      Description

      in the edge case where a previous build's commit no longer exists in the repository (as when, for example, the repository is replaced), the comand

      git whatchanged --no-abbrev -M --pretty=raw <nonexistent hash>..<current TARGET>

      as executed by the git plugin will return the entire history of the repository, up to TARGET. This can use a lot of memory, and was causing a heapsize error for my slaves.

      The plugin should probably check for the existence of the previous commit, and handle it's nonexistence more gracefully (perhaps force a wipe of the workspace? or fail with an error message suggesting the user wipe the workspace?)

        Activity

        Hide
        dogfood dogfood added a comment -

        Integrated in plugins_git-plugin #91
        [FIXED JENKINS-8853] When previous build commit no longer exists in repository, don't try to do full history as changelog.

        Andrew Bayer :
        Files :

        • src/main/java/hudson/plugins/git/GitAPI.java
        • src/main/java/hudson/plugins/git/IGitAPI.java
        • src/main/java/hudson/plugins/git/GitSCM.java
        Show
        dogfood dogfood added a comment - Integrated in plugins_git-plugin #91 [FIXED JENKINS-8853] When previous build commit no longer exists in repository, don't try to do full history as changelog. Andrew Bayer : Files : src/main/java/hudson/plugins/git/GitAPI.java src/main/java/hudson/plugins/git/IGitAPI.java src/main/java/hudson/plugins/git/GitSCM.java
        Hide
        evernat evernat added a comment -

        It is committed, so I suppose it is fixed.

        Show
        evernat evernat added a comment - It is committed, so I suppose it is fixed.

          People

          • Assignee:
            abayer abayer
            Reporter:
            evilchili evilchili
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: