Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8990

Ping interval for JNLP slaves should be configurable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None

      Description

      JNLP slaves have a fixed 10 minute ping interval to keep the connection alive. However, some people have proxies with a shorter timeout. The ping interval should be configurable.

      This idea has been mentioned before, for example at http://jenkins.361315.n4.nabble.com/JNLP-Slave-client-disconnects-connection-automatically-tp3309341p3313395.html

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Nathan Parry
        Path:
        core/src/main/java/hudson/slaves/ChannelPinger.java
        remoting/src/main/java/hudson/remoting/Engine.java
        http://jenkins-ci.org/commit/jenkins/18327e9de69b2937ce29730071ba818899c7ac51
        Log:
        [FIXED JENKINS-8990] Configurable ping interval

        This lets you configure the ping interval for slaves via a
        system property. (hudson.slaves.ChannelPinger.pingInterval)

        The default ping interval has been lowered from 10 to 5 minutes.

        It also moves the ping setup logic into a ComputerListener
        (out of the JNLP slave Engine class). As a side effect, all
        slaves will now have a ping instead of just JNLP slaves.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nathan Parry Path: core/src/main/java/hudson/slaves/ChannelPinger.java remoting/src/main/java/hudson/remoting/Engine.java http://jenkins-ci.org/commit/jenkins/18327e9de69b2937ce29730071ba818899c7ac51 Log: [FIXED JENKINS-8990] Configurable ping interval This lets you configure the ping interval for slaves via a system property. (hudson.slaves.ChannelPinger.pingInterval) The default ping interval has been lowered from 10 to 5 minutes. It also moves the ping setup logic into a ComputerListener (out of the JNLP slave Engine class). As a side effect, all slaves will now have a ping instead of just JNLP slaves.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -
        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/9c8fcf2e75f13312b1c7067716aaef0b5b95d61e Log: recording JENKINS-8990 fix Compare: https://github.com/jenkinsci/jenkins/compare/67cd5b4...9c8fcf2
        Hide
        dogfood dogfood added a comment -

        Integrated in jenkins_main_trunk #620
        [FIXED JENKINS-8990] Configurable ping interval
        recording JENKINS-8990 fix

        Kohsuke Kawaguchi : 18327e9de69b2937ce29730071ba818899c7ac51
        Files :

        • core/src/main/java/hudson/slaves/ChannelPinger.java
        • remoting/src/main/java/hudson/remoting/Engine.java

        Kohsuke Kawaguchi : 9c8fcf2e75f13312b1c7067716aaef0b5b95d61e
        Files :

        • changelog.html
        Show
        dogfood dogfood added a comment - Integrated in jenkins_main_trunk #620 [FIXED JENKINS-8990] Configurable ping interval recording JENKINS-8990 fix Kohsuke Kawaguchi : 18327e9de69b2937ce29730071ba818899c7ac51 Files : core/src/main/java/hudson/slaves/ChannelPinger.java remoting/src/main/java/hudson/remoting/Engine.java Kohsuke Kawaguchi : 9c8fcf2e75f13312b1c7067716aaef0b5b95d61e Files : changelog.html
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Nathan Parry
        Path:
        core/src/main/java/hudson/slaves/ChannelPinger.java
        remoting/src/main/java/hudson/remoting/Engine.java
        http://jenkins-ci.org/commit/jenkins/18327e9de69b2937ce29730071ba818899c7ac51
        Log:
        [FIXED JENKINS-8990] Configurable ping interval

        This lets you configure the ping interval for slaves via a
        system property. (hudson.slaves.ChannelPinger.pingInterval)

        The default ping interval has been lowered from 10 to 5 minutes.

        It also moves the ping setup logic into a ComputerListener
        (out of the JNLP slave Engine class). As a side effect, all
        slaves will now have a ping instead of just JNLP slaves.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nathan Parry Path: core/src/main/java/hudson/slaves/ChannelPinger.java remoting/src/main/java/hudson/remoting/Engine.java http://jenkins-ci.org/commit/jenkins/18327e9de69b2937ce29730071ba818899c7ac51 Log: [FIXED JENKINS-8990] Configurable ping interval This lets you configure the ping interval for slaves via a system property. (hudson.slaves.ChannelPinger.pingInterval) The default ping interval has been lowered from 10 to 5 minutes. It also moves the ping setup logic into a ComputerListener (out of the JNLP slave Engine class). As a side effect, all slaves will now have a ping instead of just JNLP slaves.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        changelog.html
        http://jenkins-ci.org/commit/jenkins/9c8fcf2e75f13312b1c7067716aaef0b5b95d61e
        Log:
        recording JENKINS-8990 fix

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/9c8fcf2e75f13312b1c7067716aaef0b5b95d61e Log: recording JENKINS-8990 fix

          People

          • Assignee:
            Unassigned
            Reporter:
            nparry Nathan Parry
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: