Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9072

Incremental builds: Marking modules not being build early, doesn't work with maven 3 projects

    Details

    • Similar Issues:

      Description

      For maven2 projects we have a mechanism which marks all modules which are not actually being build in an incremental build as NOT_BUILT already early in the reactor build.
      See MavenModuleSetBuild$Builder#preBuild

      For maven3 this doesn't work anymore, as it uses a different builder Maven3Builder

        Attachments

          Issue Links

            Activity

            Hide
            kutzi kutzi added a comment -

            This is probably also breaking JENKINS-6544 as that issue is depending on the NOT_BUILT state being set early

            Show
            kutzi kutzi added a comment - This is probably also breaking JENKINS-6544 as that issue is depending on the NOT_BUILT state being set early
            Hide
            olamy Olivier Lamy added a comment -

            note : try to do this in maven 3 executionListener#sessionStarted (we can probably konw here which projects will be build)

            Show
            olamy Olivier Lamy added a comment - note : try to do this in maven 3 executionListener#sessionStarted (we can probably konw here which projects will be build)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
            http://jenkins-ci.org/commit/jenkins/d882ce50518f69107bb840fee0b85bc22c7d19d6
            Log:
            [FIXED JENKINS-9072] Incremental builds: Marking modules not being
            build early, doesn't work with maven 3 projects

            Compare: https://github.com/jenkinsci/jenkins/compare/6c12a64...d882ce5

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/Maven3Builder.java http://jenkins-ci.org/commit/jenkins/d882ce50518f69107bb840fee0b85bc22c7d19d6 Log: [FIXED JENKINS-9072] Incremental builds: Marking modules not being build early, doesn't work with maven 3 projects Compare: https://github.com/jenkinsci/jenkins/compare/6c12a64...d882ce5
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75
            Log:
            record changes for JENKINS-5764 and JENKINS-9072

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75 Log: record changes for JENKINS-5764 and JENKINS-9072
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #622
            [FIXED JENKINS-9072] Incremental builds: Marking modules not being

            Christoph Kutzinski : d882ce50518f69107bb840fee0b85bc22c7d19d6
            Files :

            • maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #622 [FIXED JENKINS-9072] Incremental builds: Marking modules not being Christoph Kutzinski : d882ce50518f69107bb840fee0b85bc22c7d19d6 Files : maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
            http://jenkins-ci.org/commit/jenkins/d882ce50518f69107bb840fee0b85bc22c7d19d6
            Log:
            [FIXED JENKINS-9072] Incremental builds: Marking modules not being
            build early, doesn't work with maven 3 projects

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/Maven3Builder.java http://jenkins-ci.org/commit/jenkins/d882ce50518f69107bb840fee0b85bc22c7d19d6 Log: [FIXED JENKINS-9072] Incremental builds: Marking modules not being build early, doesn't work with maven 3 projects
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75
            Log:
            record changes for JENKINS-5764 and JENKINS-9072

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/27871ce1df3cebdcffd3e2992c21c92a8696df75 Log: record changes for JENKINS-5764 and JENKINS-9072
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/maven/Maven3Builder.java
            http://jenkins-ci.org/commit/maven-plugin/325f7ab5668351c6cc6f14fcb3eabe04af005162
            Log:
            [FIXED JENKINS-9072] Incremental builds: Marking modules not being
            build early, doesn't work with maven 3 projects
            Originally-Committed-As: d882ce50518f69107bb840fee0b85bc22c7d19d6

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/Maven3Builder.java http://jenkins-ci.org/commit/maven-plugin/325f7ab5668351c6cc6f14fcb3eabe04af005162 Log: [FIXED JENKINS-9072] Incremental builds: Marking modules not being build early, doesn't work with maven 3 projects Originally-Committed-As: d882ce50518f69107bb840fee0b85bc22c7d19d6

              People

              • Assignee:
                kutzi kutzi
                Reporter:
                kutzi kutzi
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: