Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9203

timer expires, and build is halted, but build is not marked as failed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: build-timeout-plugin
    • Labels:
      None
    • Environment:
      Debian Lenny, Jenkins ver. 1.404 and build-timeout ver. 1.7

      Description

      I just installed the build-timeout plugin and it's mostly working, but
      even with the "Fail the build" setting checked, my builds are still
      being marked as "aborted":

      For example, here is the tail of the console output:
      {{
      [...]
      Build timed out (after 3 minutes). Marking the build as failed.
      Terminated
      +++ vncserver -kill beast:3 -clean
      Killing Xtightvnc process ID 12328
      +++ exit
      Finished: ABORTED
      }}

      Note that it says it will fail the build, but then it is aborted and
      the status of the build is set to aborted, not failed. Bonus pain:
      Of course no email goes out.

      This is with Jenkins ver. 1.404 and build-timeout ver. 1.7.

        Issue Links

          Activity

          Hide
          jlpinardon jlpinardon added a comment - - edited

          And also, if a build is configured to be triggered when the "timed out" build is failed, the build is not triggered.

          Our Configuration :
          Hudson Master SUN OS 10
          Java 1.6.0.18
          Jenkins 1.404
          Build Timeout 1.7

          Hudson Slave :
          Linux RH5
          java 1.6.0_21-b06

          A Test done with a Hudson 1.395 and BuildTimeOut 1.6 shows that it was OK with these couple of version.

          Show
          jlpinardon jlpinardon added a comment - - edited And also, if a build is configured to be triggered when the "timed out" build is failed, the build is not triggered. Our Configuration : Hudson Master SUN OS 10 Java 1.6.0.18 Jenkins 1.404 Build Timeout 1.7 Hudson Slave : Linux RH5 java 1.6.0_21-b06 A Test done with a Hudson 1.395 and BuildTimeOut 1.6 shows that it was OK with these couple of version.
          Hide
          redsolo redsolo added a comment -

          Im seeing this as well. Jenkins 1.404, build-timeout plugin 1.7.

          java.runtime.name Java(TM) SE Runtime Environment 1.6.0_24-b07
          java.vm.name Java HotSpot(TM) 64-Bit Server VM
          os.arch amd64
          os.name Linux
          os.version 2.6.18-238.1.1.el5

          Output at the end of the log:

          Build timed out (after 15 minutes). Marking the build as failed.
          Finished: ABORTED
          
          Show
          redsolo redsolo added a comment - Im seeing this as well. Jenkins 1.404, build-timeout plugin 1.7. java.runtime.name Java(TM) SE Runtime Environment 1.6.0_24-b07 java.vm.name Java HotSpot(TM) 64-Bit Server VM os.arch amd64 os.name Linux os.version 2.6.18-238.1.1.el5 Output at the end of the log: Build timed out (after 15 minutes). Marking the build as failed. Finished: ABORTED
          Hide
          redsolo redsolo added a comment -

          This bug was introduced in Jenkins version 1.398. 1.397 works fine, but 1.398-404 doesnt. I dont know how to fix it, but I have created an integration test case to show the problem in 1.398+.

          Show
          redsolo redsolo added a comment - This bug was introduced in Jenkins version 1.398. 1.397 works fine, but 1.398-404 doesnt. I dont know how to fix it, but I have created an integration test case to show the problem in 1.398+.
          Hide
          asmundo Asmund Ostvold added a comment -

          The LTS(RC) version Jenkins ver. 1.400.1-SNAPSHOT (private-05/12/2011 11:17-kohsuke). Downloaded today do have the same issue. If the fix has low risk a back port of it the coming fix would be appreciated

          Show
          asmundo Asmund Ostvold added a comment - The LTS(RC) version Jenkins ver. 1.400.1-SNAPSHOT (private-05/12/2011 11:17-kohsuke). Downloaded today do have the same issue. If the fix has low risk a back port of it the coming fix would be appreciated
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          This regression was induced by 9c965617b3b385ef65eaf50860865c05a114a01d which refers to JENKINS-7864 and JENKINS-8054. Still investigating.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - This regression was induced by 9c965617b3b385ef65eaf50860865c05a114a01d which refers to JENKINS-7864 and JENKINS-8054 . Still investigating.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/matrix/MatrixBuild.java
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Executor.java
          core/src/main/java/hudson/model/Result.java
          core/src/main/java/hudson/model/Run.java
          maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
          maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
          maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java
          http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Log:
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/matrix/MatrixBuild.java core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/Result.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/Maven3Builder.java maven-plugin/src/main/java/hudson/maven/MavenBuilder.java maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6 Log: [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #886
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Kohsuke Kawaguchi : a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Files :

          • core/src/main/java/hudson/matrix/MatrixBuild.java
          • core/src/main/java/hudson/model/Result.java
          • core/src/main/java/hudson/model/Executor.java
          • changelog.html
          • test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java
          • maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
          • core/src/main/java/hudson/model/Build.java
          • maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          • core/src/main/java/hudson/model/Run.java
          • maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #886 [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status. Kohsuke Kawaguchi : a3354b12cfc5f554487b59f35e5a0bdbce8861a6 Files : core/src/main/java/hudson/matrix/MatrixBuild.java core/src/main/java/hudson/model/Result.java core/src/main/java/hudson/model/Executor.java changelog.html test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java maven-plugin/src/main/java/hudson/maven/Maven3Builder.java core/src/main/java/hudson/model/Build.java maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          I marked this closed incorrectly. The plugin still needs to be updated to take advantage of this new feature in the core 1.417.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - I marked this closed incorrectly. The plugin still needs to be updated to take advantage of this new feature in the core 1.417.
          Hide
          ndeloof Nicolas De Loof added a comment -

          fixed at 5488c0cf16fd49dcf0bb3a73156faa18bea49a17

          Show
          ndeloof Nicolas De Loof added a comment - fixed at 5488c0cf16fd49dcf0bb3a73156faa18bea49a17
          Hide
          pickgr1 pickgr1 added a comment -

          Is a fix available for this somewhere? According to the wiki for the plugin, the latest version is 1.7 and was released on 3/20/2011

          https://wiki.jenkins-ci.org/display/JENKINS/Build-timeout+Plugin

          Show
          pickgr1 pickgr1 added a comment - Is a fix available for this somewhere? According to the wiki for the plugin, the latest version is 1.7 and was released on 3/20/2011 https://wiki.jenkins-ci.org/display/JENKINS/Build-timeout+Plugin
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: redsolo
          Path:
          src/test/java/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest.java
          src/test/resources/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest/testIssue9203.zip
          http://jenkins-ci.org/commit/build-timeout-plugin/7485913f4faea9d8a0b1344662f58632be86c313
          Log:
          JENKINS-9203 Added integration test case that fails under 1.398 but not under 1.397

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: redsolo Path: src/test/java/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest.java src/test/resources/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest/testIssue9203.zip http://jenkins-ci.org/commit/build-timeout-plugin/7485913f4faea9d8a0b1344662f58632be86c313 Log: JENKINS-9203 Added integration test case that fails under 1.398 but not under 1.397
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          pom.xml
          src/main/java/hudson/plugins/build_timeout/BuildTimeoutWrapper.java
          http://jenkins-ci.org/commit/build-timeout-plugin/36c0385367fce3645b6782e4228315e35bfdefdd
          Log:
          [FIXED JENKINS-9203] mark the build as failure by using the new API

          Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/a065565...36c0385

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: pom.xml src/main/java/hudson/plugins/build_timeout/BuildTimeoutWrapper.java http://jenkins-ci.org/commit/build-timeout-plugin/36c0385367fce3645b6782e4228315e35bfdefdd Log: [FIXED JENKINS-9203] mark the build as failure by using the new API Compare: https://github.com/jenkinsci/build-timeout-plugin/compare/a065565...36c0385
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_build-timeout #16
          JENKINS-9203 Added integration test case that fails under 1.398 but not under 1.397
          [FIXED JENKINS-9203] mark the build as failure by using the new API

          redsolo :
          Files :

          • src/test/java/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest.java
          • src/test/resources/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest/testIssue9203.zip

          Kohsuke Kawaguchi :
          Files :

          • pom.xml
          • src/main/java/hudson/plugins/build_timeout/BuildTimeoutWrapper.java
          Show
          dogfood dogfood added a comment - Integrated in plugins_build-timeout #16 JENKINS-9203 Added integration test case that fails under 1.398 but not under 1.397 [FIXED JENKINS-9203] mark the build as failure by using the new API redsolo : Files : src/test/java/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest.java src/test/resources/hudson/plugins/build_timeout/BuildTimeoutWrapperIntegrationTest/testIssue9203.zip Kohsuke Kawaguchi : Files : pom.xml src/main/java/hudson/plugins/build_timeout/BuildTimeoutWrapper.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/matrix/MatrixBuild.java
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Executor.java
          core/src/main/java/hudson/model/Result.java
          core/src/main/java/hudson/model/Run.java
          maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
          maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
          maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java
          http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Log:
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/matrix/MatrixBuild.java core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/Result.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/Maven3Builder.java maven-plugin/src/main/java/hudson/maven/MavenBuilder.java maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6 Log: [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/matrix/MatrixBuild.java
          core/src/main/java/hudson/model/Build.java
          core/src/main/java/hudson/model/Executor.java
          core/src/main/java/hudson/model/Result.java
          core/src/main/java/hudson/model/Run.java
          maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
          maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
          maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java
          http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Log:
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/matrix/MatrixBuild.java core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/Result.java core/src/main/java/hudson/model/Run.java maven-plugin/src/main/java/hudson/maven/Maven3Builder.java maven-plugin/src/main/java/hudson/maven/MavenBuilder.java maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java test/src/test/java/hudson/model/AbortedFreeStyleBuildTest.java http://jenkins-ci.org/commit/jenkins/a3354b12cfc5f554487b59f35e5a0bdbce8861a6 Log: [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/matrix/MatrixBuild.java
          http://jenkins-ci.org/commit/matrix-project-plugin/7cab552d387727d1af3e5fa277ea4503bdc6242e
          Log:
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Originally-Committed-As: a3354b12cfc5f554487b59f35e5a0bdbce8861a6

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/matrix/MatrixBuild.java http://jenkins-ci.org/commit/matrix-project-plugin/7cab552d387727d1af3e5fa277ea4503bdc6242e Log: [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status. Originally-Committed-As: a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          src/main/java/hudson/maven/Maven3Builder.java
          src/main/java/hudson/maven/MavenBuilder.java
          src/main/java/hudson/maven/MavenModuleSetBuild.java
          http://jenkins-ci.org/commit/maven-plugin/a8a6efc5cab02b40c1af6f19c9b8f648f8713976
          Log:
          [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status.

          Originally-Committed-As: a3354b12cfc5f554487b59f35e5a0bdbce8861a6

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/main/java/hudson/maven/Maven3Builder.java src/main/java/hudson/maven/MavenBuilder.java src/main/java/hudson/maven/MavenModuleSetBuild.java http://jenkins-ci.org/commit/maven-plugin/a8a6efc5cab02b40c1af6f19c9b8f648f8713976 Log: [FIXED JENKINS-9203] in light of 9c965617b3b385ef65eaf50860865c05a114a01d, I think the proper fix is to define a mechanism to abort with status. Originally-Committed-As: a3354b12cfc5f554487b59f35e5a0bdbce8861a6
          Hide
          crouleau Colden Rouleau added a comment -

          I am using:
          Jenkins 1.580
          build timeout plugin 1.14

          I am trying to get the "fail the build" functionality to work, but instead the build is just getting aborted. Here is what I get at the end of the log file:

          Build timed out (after 3 minutes). Marking the build as failed.
          Build was aborted
          Finished: ABORTED

          I apologize if this is the wrong place to post, but it appears to be the same issue, perhaps coming back again.

          Show
          crouleau Colden Rouleau added a comment - I am using: Jenkins 1.580 build timeout plugin 1.14 I am trying to get the "fail the build" functionality to work, but instead the build is just getting aborted. Here is what I get at the end of the log file: Build timed out (after 3 minutes). Marking the build as failed. Build was aborted Finished: ABORTED I apologize if this is the wrong place to post, but it appears to be the same issue, perhaps coming back again.
          Hide
          danielbeck Daniel Beck added a comment -

          Colden Rouleau: Please file a new issue against the core component. Provide as much information as you can, and link back to this issue for reference. If possible, include full instructions how to reproduce the problem on a new Jenkins instance. See also https://wiki.jenkins-ci.org/display/JENKINS/How+to+report+an+issue (FWIW I cannot reproduce the issue on my test instance, so be extra specific)

          Show
          danielbeck Daniel Beck added a comment - Colden Rouleau : Please file a new issue against the core component. Provide as much information as you can, and link back to this issue for reference. If possible, include full instructions how to reproduce the problem on a new Jenkins instance. See also https://wiki.jenkins-ci.org/display/JENKINS/How+to+report+an+issue (FWIW I cannot reproduce the issue on my test instance, so be extra specific)
          Hide
          crouleau Colden Rouleau added a comment -

          Hey, so I'm not 100% sure what happened, but right after I posted my last message I changed the build from a static timeout (which I was using for testing purposes) to use an elastic timeout strategy. 35 minutes later, I got a failure notification email. So clearly, the elastic timeout works fine. I'm not sure what happened there, but I suppose there's no issue as far as I'm concerned.

          This was what was at the end of the log:

          Build timed out (after 35 minutes). Marking the build as failed.
          Build was aborted
          Sending e-mails to: myemail@something.com
          Finished: FAILURE

          Show
          crouleau Colden Rouleau added a comment - Hey, so I'm not 100% sure what happened, but right after I posted my last message I changed the build from a static timeout (which I was using for testing purposes) to use an elastic timeout strategy. 35 minutes later, I got a failure notification email. So clearly, the elastic timeout works fine. I'm not sure what happened there, but I suppose there's no issue as far as I'm concerned. This was what was at the end of the log: Build timed out (after 35 minutes). Marking the build as failed. Build was aborted Sending e-mails to: myemail@something.com Finished: FAILURE

            People

            • Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              eengstrom Eric Engstrom
            • Votes:
              9 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: