Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9415

Misleading result of "Check AMI" validation button

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: ec2-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      "Check AMI" validation button results into "No such AMI, or not usable with this accessId" in spite of the fact that AMI can be provisioned (when ignoring the warning, AMI is provisioned and running)

        Attachments

          Activity

          Hide
          vjuranek vjuranek added a comment -

          it's because of
          users.add("self");
          in SlaveTemplate.doValidateAmi()
          as adding users cause, that only intersection of requested ami with set of amis where user has explicit launch permission is returned (which is often empty set). IMHO empty user setup should be sufficient, according to http://docs.amazonwebservices.com/AWSEC2/latest/CommandLineReference/index.html?ApiReference-cmd-DescribeImages.html :
          ??If you specify one or more AMI IDs, only AMIs that have the specified IDs are returned. ... If you specify an AMI ID for which you do not have access, it will not be included in the returned results. ??

          Show
          vjuranek vjuranek added a comment - it's because of users.add("self"); in SlaveTemplate.doValidateAmi() as adding users cause, that only intersection of requested ami with set of amis where user has explicit launch permission is returned (which is often empty set). IMHO empty user setup should be sufficient, according to http://docs.amazonwebservices.com/AWSEC2/latest/CommandLineReference/index.html?ApiReference-cmd-DescribeImages.html : ??If you specify one or more AMI IDs, only AMIs that have the specified IDs are returned. ... If you specify an AMI ID for which you do not have access, it will not be included in the returned results. ??
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          http://jenkins-ci.org/commit/ec2-plugin/c1e1de9a8ee1173c7131881d14abf53b0aebcad1
          Log:
          Fix for JENKINS-9415

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: src/main/java/hudson/plugins/ec2/SlaveTemplate.java http://jenkins-ci.org/commit/ec2-plugin/c1e1de9a8ee1173c7131881d14abf53b0aebcad1 Log: Fix for JENKINS-9415
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          http://jenkins-ci.org/commit/ec2-plugin/3e5ed1662f8c2dffdee23ab96d767e156056f19f
          Log:
          Merge pull request #9 from vjuranek/JENKINS-9415

          [FIXED JENKINS-9415]

          Compare: https://github.com/jenkinsci/ec2-plugin/compare/ecdd3b9...3e5ed16

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/main/java/hudson/plugins/ec2/SlaveTemplate.java http://jenkins-ci.org/commit/ec2-plugin/3e5ed1662f8c2dffdee23ab96d767e156056f19f Log: Merge pull request #9 from vjuranek/ JENKINS-9415 [FIXED JENKINS-9415] Compare: https://github.com/jenkinsci/ec2-plugin/compare/ecdd3b9...3e5ed16
          Hide
          jacob_robertson Jacob Robertson added a comment -

          This issue is a blocker for me. Could we get a release of this plugin so we could make use of this fix?

          Show
          jacob_robertson Jacob Robertson added a comment - This issue is a blocker for me. Could we get a release of this plugin so we could make use of this fix?
          Hide
          vjuranek vjuranek added a comment -

          1.12 released, should be available in a few hours in update center.

          Show
          vjuranek vjuranek added a comment - 1.12 released, should be available in a few hours in update center.

            People

            • Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              vjuranek vjuranek
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: