Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9694

Ircbot is not limited to its user's access restrictions

    Details

    • Similar Issues:

      Description

      When using the ircbot, it should be limited to the access of the user which is specified in the advanced options.
      When I installed Jenkins and configured the ircbot to login, it simply accepts any command from any user in query or in a channel.
      It appears to never be limited to its user, even when the user is invalid, and instead complains in the log about invalid user, but the command is executed anyway.
      Might have missed something, but AFAICT it simply isn't working.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kutzi
          Path:
          src/main/java/hudson/plugins/im/bot/BuildCommand.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/b43fe93ee8970d665e44fc64318e791ffd3b6f58
          Log:
          JENKINS-9694 bot permissions didn't apply for build command

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kutzi Path: src/main/java/hudson/plugins/im/bot/BuildCommand.java http://jenkins-ci.org/commit/instant-messaging-plugin/b43fe93ee8970d665e44fc64318e791ffd3b6f58 Log: JENKINS-9694 bot permissions didn't apply for build command
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kutzi
          Path:
          src/main/java/hudson/plugins/im/bot/BuildCommand.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/b43fe93ee8970d665e44fc64318e791ffd3b6f58
          Log:
          JENKINS-9694 bot permissions didn't apply for build command

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kutzi Path: src/main/java/hudson/plugins/im/bot/BuildCommand.java http://jenkins-ci.org/commit/instant-messaging-plugin/b43fe93ee8970d665e44fc64318e791ffd3b6f58 Log: JENKINS-9694 bot permissions didn't apply for build command
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/im/bot/UserStatCommand.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/fc92b63f40f68313582ea33f67d6184c218db5f8
          Log:
          JENKINS-9694 bot permissions didn't apply for userstat command

          Compare: https://github.com/jenkinsci/instant-messaging-plugin/compare/07c4e59...fc92b63

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/bot/UserStatCommand.java http://jenkins-ci.org/commit/instant-messaging-plugin/fc92b63f40f68313582ea33f67d6184c218db5f8 Log: JENKINS-9694 bot permissions didn't apply for userstat command Compare: https://github.com/jenkinsci/instant-messaging-plugin/compare/07c4e59...fc92b63
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/im/bot/UserStatCommand.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/3be1be9fb4bd01cff209ffebde9202cd0ae8f193
          Log:
          JENKINS-9694 bot permissions didn't apply for userstat command

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/bot/UserStatCommand.java http://jenkins-ci.org/commit/instant-messaging-plugin/3be1be9fb4bd01cff209ffebde9202cd0ae8f193 Log: JENKINS-9694 bot permissions didn't apply for userstat command
          Hide
          kutzi kutzi added a comment -

          I still have to check all other commands, but I've fixed it for the most sensitive commands build and userstat, already.

          Show
          kutzi kutzi added a comment - I still have to check all other commands, but I've fixed it for the most sensitive commands build and userstat, already.
          Hide
          kutzi kutzi added a comment -

          Fixed in instant-messaging 1.17

          Show
          kutzi kutzi added a comment - Fixed in instant-messaging 1.17

            People

            • Assignee:
              kutzi kutzi
              Reporter:
              bluematt Matt Corallo
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: