Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9856

Jenkins Check-out Strategy for SVN causes files outside of workspace to be deleted

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      This is similar to https://issues.jenkins-ci.org/browse/JENKINS-585

      The difference is that when I checked in a symlink into the repository and Jenkins checked it out, when performing the action to "Emulate Clean Checkout...", it follows symlinks and deletes all the files in that directory.

      The unfortunate part is that it wiped out an entire server's shared directory.

        Attachments

          Issue Links

            Activity

            Hide
            g01 Gary Yund added a comment -

            Updated to Critical as it causes loss of data and files on the file system

            Show
            g01 Gary Yund added a comment - Updated to Critical as it causes loss of data and files on the file system
            Hide
            g01 Gary Yund added a comment -

            Temporary fix is to deny the Jenkins server write access to that directory.

            Show
            g01 Gary Yund added a comment - Temporary fix is to deny the Jenkins server write access to that directory.
            Hide
            dogfood dogfood added a comment -

            Integrated in plugins_subversion #93
            [FIXED JENKINS-9856]
            I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it.

            But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit.

            kohsuke :
            Files :

            • /trunk/hudson/plugins/subversion/src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java
            Show
            dogfood dogfood added a comment - Integrated in plugins_subversion #93 [FIXED JENKINS-9856] I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it. But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit. kohsuke : Files : /trunk/hudson/plugins/subversion/src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kohsuke
            Path:
            src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/21d95f30cefe2fec98da488a3da84a7e94d5312a
            Log:
            [FIXED JENKINS-9856]
            I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it.

            But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kohsuke Path: src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java http://jenkins-ci.org/commit/subversion-plugin/21d95f30cefe2fec98da488a3da84a7e94d5312a Log: [FIXED JENKINS-9856] I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it. But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kohsuke
            Path:
            src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java
            http://jenkins-ci.org/commit/subversion-plugin/21d95f30cefe2fec98da488a3da84a7e94d5312a
            Log:
            [FIXED JENKINS-9856]
            I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it.

            But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kohsuke Path: src/main/java/hudson/scm/subversion/UpdateWithCleanUpdater.java http://jenkins-ci.org/commit/subversion-plugin/21d95f30cefe2fec98da488a3da84a7e94d5312a Log: [FIXED JENKINS-9856] I couldn't reproduce the exact problem in case of symlink checked into the repository — AFAICT, unless symlink gets updated or altered, it won't get into the code that deletes it. But in general, I can see that unversioned symlink in the workspace would cause the problem described, which is what I'm fixing in this commit.

              People

              • Assignee:
                Unassigned
                Reporter:
                g01 Gary Yund
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: