Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9960

Plugin Dependencies not started before plugin in HudsonTestCase

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Component/s: plugin-proposals
    • Labels:
      None

      Description

      While plugins are started in the correct order when deployed normally (and via hpi:run), the upstream plugin is not started before the dependent plugin when run under HudsonTestCase.

      Steps to reproduce:

      git clone git://github.com/recampbell/jenkins-plugin-bugs.git
      cd jenkins-plugin-bugs/JENKINS-9960
      mvn clean install

        Activity

        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        changelog.html
        core/src/main/java/hudson/PluginManager.java
        core/src/main/java/hudson/util/CyclicGraphDetector.java
        plugins/pom.xml
        pom.xml
        http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
        Log:
        [FIXED JENKINS-9960]

        We weren't actually enforcing the initialization order at all, as
        sorting was based on the plugin name.

        Compare: https://github.com/jenkinsci/jenkins/compare/938ac77...e03ba7d

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name. Compare: https://github.com/jenkinsci/jenkins/compare/938ac77...e03ba7d
        Hide
        dogfood dogfood added a comment -

        Integrated in jenkins_main_trunk #871
        [FIXED JENKINS-9960]

        Kohsuke Kawaguchi : e03ba7dc6ba3753ed18d0de02133734ab171fb21
        Files :

        • core/src/main/java/hudson/PluginManager.java
        • changelog.html
        • core/src/main/java/hudson/util/CyclicGraphDetector.java
        • plugins/pom.xml
        • pom.xml
        Show
        dogfood dogfood added a comment - Integrated in jenkins_main_trunk #871 [FIXED JENKINS-9960] Kohsuke Kawaguchi : e03ba7dc6ba3753ed18d0de02133734ab171fb21 Files : core/src/main/java/hudson/PluginManager.java changelog.html core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        changelog.html
        core/src/main/java/hudson/PluginManager.java
        core/src/main/java/hudson/util/CyclicGraphDetector.java
        plugins/pom.xml
        pom.xml
        http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
        Log:
        [FIXED JENKINS-9960]

        We weren't actually enforcing the initialization order at all, as
        sorting was based on the plugin name.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        changelog.html
        core/src/main/java/hudson/PluginManager.java
        core/src/main/java/hudson/util/CyclicGraphDetector.java
        plugins/pom.xml
        pom.xml
        http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
        Log:
        [FIXED JENKINS-9960]

        We weren't actually enforcing the initialization order at all, as
        sorting was based on the plugin name.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name.

          People

          • Assignee:
            Unassigned
            Reporter:
            recampbell recampbell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: