Details

    • Type: Improvement
    • Status: Done (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: plugin-site
    • Labels:
      None
    • Similar Issues:

      Description

      As Fritz Elfert points out in https://groups.google.com/d/msg/jenkinsci-dev/t_qgJ4PEOz8/9y1_ldtvDgAJ the current links to GitHub repositories are based solely on convention based on artifactId.

      While that's the case for most repositories, for some, this convention doesn't apply, mostly due to unfortunately chosen artifactIds that would result in very weird repo names.

      It would probably be good if the update site provided an optional element with the browsable SCM URL.

      Plan of attack:

      1. (Michael) Remove GitHub links for now ('changes' URLs are gone for good since we can't know SCM tags for sure, but the basic link, currently labeled 'GitHub', will be back)
      2. (Daniel) Discuss with the community the reuse of the 'scm' entry in update-center.json or whether we need a new entry
      3. (Daniel) Extend update-center.json with the browsable SCM URL (likely taken from /project/scm/url in the POM, or tried to extract from the developerConnection for more compatibility)
      4. (Michael) Adapt the plugin site generator to add support for this element
      5. (Michael) Adapt the plugin site to use this element to build links, and only link anywhere when it's set.

        Attachments

          Issue Links

            Activity

            Hide
            mmccaskill Michael McCaskill added a comment -

            Daniel Beck Step 1 is now deployed to production.

            Show
            mmccaskill Michael McCaskill added a comment - Daniel Beck Step 1 is now deployed to production.
            Hide
            danielbeck Daniel Beck added a comment -

            Step 2 yielded no feedback.

            Step 3 PR at https://github.com/jenkins-infra/backend-update-center2/pull/126 merged

            Show
            danielbeck Daniel Beck added a comment - Step 2 yielded no feedback. Step 3 PR at https://github.com/jenkins-infra/backend-update-center2/pull/126 merged
            Hide
            mmccaskill Michael McCaskill added a comment -

            Step 4 here

            Step 5 PR at https://github.com/jenkins-infra/plugin-site/pull/41

            Daniel Beck - Just confirming that we're keeping the links for "sinceLatestRelease" and "inLatestRelease" out, and only showing the link to the GitHub repository.

            Show
            mmccaskill Michael McCaskill added a comment - Step 4 here Step 5 PR at https://github.com/jenkins-infra/plugin-site/pull/41 Daniel Beck - Just confirming that we're keeping the links for "sinceLatestRelease" and "inLatestRelease" out, and only showing the link to the GitHub repository.
            Hide
            danielbeck Daniel Beck added a comment -

            Just confirming that we're keeping the links for "sinceLatestRelease" and "inLatestRelease" out, and only showing the link to the GitHub repository.

            For now, yes. I'll need to find a good solution for that. As usual, there's a convention most plugins follow, but some don't – so just mechanically guessing the diff URL doesn't work.

            Show
            danielbeck Daniel Beck added a comment - Just confirming that we're keeping the links for "sinceLatestRelease" and "inLatestRelease" out, and only showing the link to the GitHub repository. For now, yes. I'll need to find a good solution for that. As usual, there's a convention most plugins follow, but some don't – so just mechanically guessing the diff URL doesn't work.
            Hide
            mmccaskill Michael McCaskill added a comment -

            Ok cool. Sounds good then.

            Show
            mmccaskill Michael McCaskill added a comment - Ok cool. Sounds good then.

              People

              • Assignee:
                mmccaskill Michael McCaskill
                Reporter:
                mmccaskill Michael McCaskill
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: