Uploaded image for project: 'Jenkins Website'
  1. Jenkins Website
  2. WEBSITE-335

Bad "Changes in X release" link for new plugins

    Details

    • Type: Improvement
    • Status: Done (View Workflow)
    • Priority: Trivial
    • Resolution: Won't Do
    • Component/s: plugin-site
    • Labels:
      None
    • Similar Issues:

      Description

      If a new plugin is released, its previousVersion is missing from the UC data — however, ScmPluginDataParser assumes the data is there, and generates a bad link to GitHub (null...1.0).

      If previousVersion is missing, this link doesn't need to be included in the page.

      (I did try to find some GitHub compare links that let you find the history from inception until the first tag.  e.g. "master@{10 years ago}..<tag>", but they don't let you go back more than about four years, and "master~10000" doesn't work without knowing the number of commits in the repo)

        Attachments

          Activity

          Hide
          mmccaskill Michael McCaskill added a comment -

          Yeah I actually thought about this today. The code you're referencing was just merged onto develop today but not onto master yet. Nonetheless I'm sure this same bug exists in master. Good catch. But ultimately this needs to wait for WEBSITE-332 to be done before I figure out how to fix this.

          Show
          mmccaskill Michael McCaskill added a comment - Yeah I actually thought about this today. The code you're referencing was just merged onto develop today but not onto master yet. Nonetheless I'm sure this same bug exists in master. Good catch. But ultimately this needs to wait for WEBSITE-332 to be done before I figure out how to fix this.
          Hide
          danielbeck Daniel Beck added a comment -

          This has been removed.

          Show
          danielbeck Daniel Beck added a comment - This has been removed.

            People

            • Assignee:
              mmccaskill Michael McCaskill
              Reporter:
              orrc Christopher Orr
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: