Uploaded image for project: 'Jenkins Website'
  1. Jenkins Website
  2. WEBSITE-374

Plugin site seems to remove all tables from wiki output, not just the stats one

    Details

    • Similar Issues:

      Description

      https://wiki.jenkins.io/display/JENKINS/Blue+Ocean+Plugin now has tables for the changelog.

      https://plugins.jenkins.io/blueocean doesn't show them.

      Hypothesis: Over-eager removal of all tables when we really only want to remove the macro-provided statistics table that's typically on top.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -
            Show
            danielbeck Daniel Beck added a comment - Another example: https://plugins.jenkins.io/vectorcast-execution
            Hide
            mmccaskill Michael McCaskill added a comment -

            Daniel Beck So I've narrowed some use cases that I want to get your opinion.

            <span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup">
            <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
            </span>
            
            <span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"></span>
            <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
            
            <p>
            <spanclass="conf-macro output-inline"data-hasbody="true"data-macro-name="unmigrated-inline-wiki-markup">
            <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
            </span>
            </p>
            

            The new algorithm is simply checking for the h4 specifically with Project Information and removing it so the span isn't being used. The only other thing is the table with all of the plugin information. Sometimes it's inside of the span, sometimes not. Not sure if we know if every plugin has one of these tables. If so it might be reasonable to assume removing the first table with class "confluenceTable" will work.

            Show
            mmccaskill Michael McCaskill added a comment - Daniel Beck So I've narrowed some use cases that I want to get your opinion. <span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> </span> <span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"></span> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> <p> <spanclass="conf-macro output-inline"data-hasbody="true"data-macro-name="unmigrated-inline-wiki-markup"> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> </span> </p> The new algorithm is simply checking for the h4 specifically with Project Information and removing it so the span isn't being used. The only other thing is the table with all of the plugin information. Sometimes it's inside of the span, sometimes not. Not sure if we know if every plugin has one of these tables. If so it might be reasonable to assume removing the first table with class "confluenceTable" will work.
            Hide
            danielbeck Daniel Beck added a comment -

            Not sure if we know if every plugin has one of these tables.

            Since the macro is optional, I expect there will be plugins without.

            If so it might be reasonable to assume removing the first table with class "confluenceTable" will work.

            Some plugin wiki pages have content above the macro table, so that wouldn't work.

            I'll simplify the macro output first, then we'll take another stab at this.

            Show
            danielbeck Daniel Beck added a comment - Not sure if we know if every plugin has one of these tables. Since the macro is optional, I expect there will be plugins without. If so it might be reasonable to assume removing the first table with class "confluenceTable" will work. Some plugin wiki pages have content above the macro table, so that wouldn't work. I'll simplify the macro output first, then we'll take another stab at this.
            Hide
            danielbeck Daniel Beck added a comment -

            Michael McCaskill PTAL https://github.com/jenkins-infra/backend-jenkins-plugin-info-plugin/pull/18 for what I hope future output looks like. It's just a table cell with mostly fixed content (plus warnings and adopt-a-plugin messages as today). No "Plugin Information" title anymore.

            Show
            danielbeck Daniel Beck added a comment - Michael McCaskill PTAL https://github.com/jenkins-infra/backend-jenkins-plugin-info-plugin/pull/18 for what I hope future output looks like. It's just a table cell with mostly fixed content (plus warnings and adopt-a-plugin messages as today). No "Plugin Information" title anymore.
            Show
            danielbeck Daniel Beck added a comment - I think between https://github.com/jenkins-infra/plugin-site-api/pull/47 https://github.com/jenkins-infra/plugin-site-api/pull/48 and https://github.com/jenkins-infra/plugin-site-api/pull/49 this is done.

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                danielbeck Daniel Beck
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: