Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10730

VSS-Plugin incremental build broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: vss-plugin
    • Labels:
      None
    • Environment:
      Jenkins ver. 1.426 with VSS-Plugin ver. 1.9
    • Similar Issues:

      Description

      Since VSS-Plugin version 1.9 my incremental build doesn't work anymore. I have a job that is triggered by SCM update. Even if there's no change in VSS repository, I get the following message:
      [poll] No previous build, so forcing an initial build.
      There are previous builds.

      I think the bug is caused by this code in compareRemoteRevisionWith():

      //If this is the build then it deserves a build.
      AbstractBuild<?, ?> lastBuild = (AbstractBuild<?,?>)project.getLastBuild();
      if(lastBuild == null)

      { tl.getLogger().println("[poll] Last Build : #" + lastBuild.getNumber()); }

      else

      { // If we've never built before, well, gotta build! tl.getLogger().println("[poll] No previous build, so forcing an initial build."); return PollingResult.BUILD_NOW; }

      The logic of the "if" statement should be the other way round; when lastBuild is null, one couldn't call getNumber() without an exception.

        Attachments

          Activity

          Hide
          rioch rioch added a comment -

          Thanks for the report. I'll take a look at this as soon as possible. I'm quite busy at the moment so it may be a couple of weeks.

          Show
          rioch rioch added a comment - Thanks for the report. I'll take a look at this as soon as possible. I'm quite busy at the moment so it may be a couple of weeks.
          Hide
          vividos Michael Fink added a comment -

          I prepared a patch for vss-plugin with a cloned git repository from github. I verified that with this patch the incremental build works again. If you look at the code, you see that the logic of the if()-expression is just backwards.

          Show
          vividos Michael Fink added a comment - I prepared a patch for vss-plugin with a cloned git repository from github. I verified that with this patch the incremental build works again. If you look at the code, you see that the logic of the if()-expression is just backwards.
          Hide
          madine Mark Madine added a comment -

          Are there any more updates on this?

          Show
          madine Mark Madine added a comment - Are there any more updates on this?
          Hide
          vividos Michael Fink added a comment -

          Unfortunately not. The attached patch fixes the specific problem, but there's no new version of the VSS-Plugin, and there seems to be at least another memory leak somewhere. Best to migrate to an other SCM...

          Show
          vividos Michael Fink added a comment - Unfortunately not. The attached patch fixes the specific problem, but there's no new version of the VSS-Plugin, and there seems to be at least another memory leak somewhere. Best to migrate to an other SCM...
          Hide
          jens876 Jens Hirschfeld added a comment -

          Would there be an update in nearer future? I have updatet to the current Version and since then I have this problem.
          How can I use the patch?

          Show
          jens876 Jens Hirschfeld added a comment - Would there be an update in nearer future? I have updatet to the current Version and since then I have this problem. How can I use the patch?
          Hide
          madine Mark Madine added a comment - - edited

          We have started moving to SVN (thankfully).
          We still use VSS, I patched the plugin locally.

          Pull the source from: https://github.com/jenkinsci/vss-plugin
          Apply the patch and build the plugin with Maven.

          Show
          madine Mark Madine added a comment - - edited We have started moving to SVN (thankfully). We still use VSS, I patched the plugin locally. Pull the source from: https://github.com/jenkinsci/vss-plugin Apply the patch and build the plugin with Maven.

            People

            • Assignee:
              Unassigned
              Reporter:
              vividos Michael Fink
            • Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: