Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10870

Fitnesse exceptions not failing a build

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: fitnesse-plugin
    • Labels:
      None
    • Environment:
      Plugins version 1.4
    • Similar Issues:

      Description

      The plugin is not treating Fitnesse exceptions as failures, instead they are being reported as ignored/skipped and the build is remains green.

        Attachments

          Activity

          Show
          swestcott Simon Westcott added a comment - Reported by another user (with patch) @ https://wiki.jenkins-ci.org/display/JENKINS/Fitnesse+Plugin?focusedCommentId=46336520#comment-46336520
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Simon Westcott
          Path:
          src/main/java/hudson/plugins/fitnesse/FitnesseResults.java
          src/main/java/hudson/plugins/fitnesse/FitnesseResultsAction.java
          src/main/resources/hudson/plugins/fitnesse/FitnesseResults/body.jelly
          src/test/java/hudson/plugins/fitnesse/FitnesseResultsTest.java
          http://jenkins-ci.org/commit/fitnesse-plugin/403d44ac01395c4e9b88a7b692f6cfd5eabef205
          Log:
          [Ref JENKINS-10870] Report exceptions as failures/wrongs instead of skipped/ignored

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Simon Westcott Path: src/main/java/hudson/plugins/fitnesse/FitnesseResults.java src/main/java/hudson/plugins/fitnesse/FitnesseResultsAction.java src/main/resources/hudson/plugins/fitnesse/FitnesseResults/body.jelly src/test/java/hudson/plugins/fitnesse/FitnesseResultsTest.java http://jenkins-ci.org/commit/fitnesse-plugin/403d44ac01395c4e9b88a7b692f6cfd5eabef205 Log: [Ref JENKINS-10870] Report exceptions as failures/wrongs instead of skipped/ignored
          Hide
          swestcott Simon Westcott added a comment -

          Successfully tested, just some UI tweaks required.

          Got results: StagingRegression (): 8 right, 0 wrong, 0 ignored, 3 exceptions
          Build step 'Publish Fitnesse results report' changed build result to FAILURE
          Finished: FAILURE

          Show
          swestcott Simon Westcott added a comment - Successfully tested, just some UI tweaks required. Got results: StagingRegression (): 8 right, 0 wrong, 0 ignored, 3 exceptions Build step 'Publish Fitnesse results report' changed build result to FAILURE Finished: FAILURE
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Simon Westcott
          Path:
          src/main/resources/hudson/plugins/fitnesse/FitnesseResults/body.jelly
          http://jenkins-ci.org/commit/fitnesse-plugin/d929afc74021e4a6b1b5202cab7d89e077cdaccb
          Log:
          [Ref JENKINS-10870] UI tweak

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Simon Westcott Path: src/main/resources/hudson/plugins/fitnesse/FitnesseResults/body.jelly http://jenkins-ci.org/commit/fitnesse-plugin/d929afc74021e4a6b1b5202cab7d89e077cdaccb Log: [Ref JENKINS-10870] UI tweak
          Hide
          swestcott Simon Westcott added a comment -

          Fixed in 1.5

          Show
          swestcott Simon Westcott added a comment - Fixed in 1.5

            People

            • Assignee:
              swestcott Simon Westcott
              Reporter:
              swestcott Simon Westcott
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: