Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11914

new expandAll method doesn't work as expected

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: token-macro-plugin
    • Labels:
      None
    • Environment:
      Token Macro Plugin 1.5
    • Similar Issues:

      Description

      The fact to call the expand method first generates an exception on the first not found token and then we don't try to expand environment and build variables.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Arnaud Héritier
          Path:
          src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java
          http://jenkins-ci.org/commit/token-macro-plugin/03ee10090e6372611cf45caa982d59eb2dd8a558
          Log:
          JENKINS-11914: new expandAll method doesn't work as expected

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Arnaud Héritier Path: src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java http://jenkins-ci.org/commit/token-macro-plugin/03ee10090e6372611cf45caa982d59eb2dd8a558 Log: JENKINS-11914 : new expandAll method doesn't work as expected
          Hide
          aheritier Arnaud Héritier added a comment -

          Fixed in 1.5.1

          Show
          aheritier Arnaud Héritier added a comment - Fixed in 1.5.1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: c3johnso
          Path:
          pom.xml
          src/main/java/org/jenkins_ci/plugins/run_condition/core/BooleanCondition.java
          src/main/java/org/jenkins_ci/plugins/run_condition/core/ExpressionCondition.java
          src/main/java/org/jenkins_ci/plugins/run_condition/core/FileExistsCondition.java
          src/main/java/org/jenkins_ci/plugins/run_condition/core/NumericalComparisonCondition.java
          src/main/java/org/jenkins_ci/plugins/run_condition/core/StringsMatchCondition.java
          http://jenkins-ci.org/commit/run-condition-plugin/d22633371add636a0bc6fc9ca6c96f329559b2b1
          Log:
          Include Env and parameters when expanding Macros

          Change TokenMacro.expand to TokenMacro.expandAll as included added in version 1.5.1
          of the TokenMacro plugin (skip 1.5.0 due to http://issues.jenkins-ci.org/browse/JENKINS-11914)

          This will now expand all macros including ones from Paramer Actions.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: c3johnso Path: pom.xml src/main/java/org/jenkins_ci/plugins/run_condition/core/BooleanCondition.java src/main/java/org/jenkins_ci/plugins/run_condition/core/ExpressionCondition.java src/main/java/org/jenkins_ci/plugins/run_condition/core/FileExistsCondition.java src/main/java/org/jenkins_ci/plugins/run_condition/core/NumericalComparisonCondition.java src/main/java/org/jenkins_ci/plugins/run_condition/core/StringsMatchCondition.java http://jenkins-ci.org/commit/run-condition-plugin/d22633371add636a0bc6fc9ca6c96f329559b2b1 Log: Include Env and parameters when expanding Macros Change TokenMacro.expand to TokenMacro.expandAll as included added in version 1.5.1 of the TokenMacro plugin (skip 1.5.0 due to http://issues.jenkins-ci.org/browse/JENKINS-11914 ) This will now expand all macros including ones from Paramer Actions.

            People

            • Assignee:
              aheritier Arnaud Héritier
              Reporter:
              aheritier Arnaud Héritier
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: