Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12263

Button "Don't keep this build forever" doesn't work on a multi-configuration build when its next build is partial

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • matrix-project-plugin
    • None
    • Jenkins 1.445
      MacOS

      According logKeep.jelly, clicking on button Don't keep this build forever calls the Run.doToggleLogKeep function that switches the Run.keepLog attribute and save the configuration.

      Once redirected on the previous page, logKeep.jelly decides to displays the button Don't keep this build forever if Run.isKeepLog() returns true.

      On freestyle projects it works well as Run.keepLog == Run.isKeepLog().

      However, on multi-configuration project Run.isKeepLog() checks that the N+1 build is not partial (ie. all configurations were run) to decide if log is kept or not (via MatrixBuild.getWhyKeepLog and MatrixBuild.isPartial).

      So if the next build is partial, the Don't keep this build forever button is always displayed even if you click on it.

      In this case it could be interesting to hide this button (maybe display why you have to keep this build), or display a button which have a "cascade" behavior (with warnings).

      Thanks!

            Unassigned Unassigned
            mansion Olivier Mansion
            Votes:
            4 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: