Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12832

check XSLT is not good enough

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The recently added check transform is really insufficient and misses a lot of cases.

      I've rewritten the XSLT and integrated it into our build using the custom tool support (which works extremely well!).

      I've attached the revised XSLT for possible integration into the tree.

        Attachments

          Activity

          Hide
          r1mikey Michael van der Westhuizen added a comment -

          Forgot to mention why we did this...

          The previous XSLT confuses failures and errors, counting failures as errors, and not counting errors at all. I noticed this quite quickly as 90% of my test cases were erroring due to segmentation violation and the plugin was reporting no problems.

          Show
          r1mikey Michael van der Westhuizen added a comment - Forgot to mention why we did this... The previous XSLT confuses failures and errors, counting failures as errors, and not counting errors at all. I noticed this quite quickly as 90% of my test cases were erroring due to segmentation violation and the plugin was reporting no problems.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/resources/org/jenkinsci/plugins/xunit/types/check-to-junit-4.xsl
          src/test/resources/org/jenkinsci/plugins/xunit/types/check/testcase1/result.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/check/testcase2/result.xml
          http://jenkins-ci.org/commit/xunit-plugin/75e70d75927da29a54b36c23a13116c356752abc
          Log:
          Fix JENKINS-12832

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/resources/org/jenkinsci/plugins/xunit/types/check-to-junit-4.xsl src/test/resources/org/jenkinsci/plugins/xunit/types/check/testcase1/result.xml src/test/resources/org/jenkinsci/plugins/xunit/types/check/testcase2/result.xml http://jenkins-ci.org/commit/xunit-plugin/75e70d75927da29a54b36c23a13116c356752abc Log: Fix JENKINS-12832
          Hide
          gbois Gregory Boissinot added a comment -

          Thanks

          Show
          gbois Gregory Boissinot added a comment - Thanks
          Hide
          nalybuites Michael Wright added a comment - - edited

          I just finished writing (and testing) a new XSLT for use with Check 0.9.9. Attached as check_unittest_to_xml.xslt

          Show
          nalybuites Michael Wright added a comment - - edited I just finished writing (and testing) a new XSLT for use with Check 0.9.9. Attached as check_unittest_to_xml.xslt
          Hide
          gbois Gregory Boissinot added a comment -

          Hi Mickael,
          It could be more suitable to raise a new issue.
          Regarding your new XSL, does it compatible with the previous XSL?
          Is it possible to analyze the impact?
          Thanks in advance.

          Show
          gbois Gregory Boissinot added a comment - Hi Mickael, It could be more suitable to raise a new issue. Regarding your new XSL, does it compatible with the previous XSL? Is it possible to analyze the impact? Thanks in advance.
          Hide
          nalybuites Michael Wright added a comment -

          Hey Gregory, The new XSLT is only compatible with Check 0.9.9, though I believe I have some XSLT lying around that is compatible with Check 0.9.3.

          Show
          nalybuites Michael Wright added a comment - Hey Gregory, The new XSLT is only compatible with Check 0.9.9, though I believe I have some XSLT lying around that is compatible with Check 0.9.3.
          Hide
          gbois Gregory Boissinot added a comment -

          Thanks Michael for your comment.
          Please could make a new issue with all XSLs and some 'Check' result reports.
          Thanks

          Show
          gbois Gregory Boissinot added a comment - Thanks Michael for your comment. Please could make a new issue with all XSLs and some 'Check' result reports. Thanks

            People

            • Assignee:
              gbois Gregory Boissinot
              Reporter:
              r1mikey Michael van der Westhuizen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: