Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Jenkins 1.454

      Description

      On the "Configure System" screen there are two identically named ("Views Tab Bar") options.
      The first one has help and lets me choose between "CountJobs Views TabBar" (an installed plugin) and "Default Views TabBar".
      The second one does not have help and its dropbox is empty.

      In config.xml there are two settings present:
      <viewsTabBar class="ws.albors.CountJobsViewsTabBar"/>
      <myViewsTabBar class="hudson.views.DefaultMyViewsTabBar"/>

        Activity

        Hide
        sroth Steve Roth added a comment -

        me too

        Show
        sroth Steve Roth added a comment - me too
        Hide
        evernat evernat added a comment -

        I do not reproduce the issue, but I do not have the Countjobs Viewstabbar plugin.
        Do you reproduce the issue?

        Show
        evernat evernat added a comment - I do not reproduce the issue, but I do not have the Countjobs Viewstabbar plugin. Do you reproduce the issue?
        Hide
        evernat evernat added a comment -

        Attributing the issue to the plugin author.

        Show
        evernat evernat added a comment - Attributing the issue to the plugin author.
        Hide
        ialbors Ignacio Albors added a comment -

        Sorry, I had missed this one.

        It doesn't have anything to do with the plugin but with core. Anyway, I've send a pull request that I think could fix the issue:

        https://github.com/jenkinsci/jenkins/pull/1141

        Show
        ialbors Ignacio Albors added a comment - Sorry, I had missed this one. It doesn't have anything to do with the plugin but with core. Anyway, I've send a pull request that I think could fix the issue: https://github.com/jenkinsci/jenkins/pull/1141
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Ignacio Albors
        Path:
        core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy
        http://jenkins-ci.org/commit/jenkins/08654048551e30e412dc17d6904c843845337067
        Log:
        JENKINS-13035 Changed the field name.

        Now it gets the right property. The dropdown shows the values
        for MyViewsTabBar extension
        and there is help icon and text.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ignacio Albors Path: core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy http://jenkins-ci.org/commit/jenkins/08654048551e30e412dc17d6904c843845337067 Log: JENKINS-13035 Changed the field name. Now it gets the right property. The dropdown shows the values for MyViewsTabBar extension and there is help icon and text.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Ignacio Albors
        Path:
        core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy
        http://jenkins-ci.org/commit/jenkins/026b03104b64189ebdcca2e7d1a869be77f7269d
        Log:
        JENKINS-13035 Only show this option when more than 1
        MyViewTabBar available.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ignacio Albors Path: core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy http://jenkins-ci.org/commit/jenkins/026b03104b64189ebdcca2e7d1a869be77f7269d Log: JENKINS-13035 Only show this option when more than 1 MyViewTabBar available.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy
        http://jenkins-ci.org/commit/jenkins/1fab590ed97befbc9198084706f480b463fce106
        Log:
        [FIXED JENKINS-13035] Merge pull request #1141

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy http://jenkins-ci.org/commit/jenkins/1fab590ed97befbc9198084706f480b463fce106 Log: [FIXED JENKINS-13035] Merge pull request #1141
        Hide
        dogfood dogfood added a comment -

        Integrated in jenkins_main_trunk #3303
        JENKINS-13035 Changed the field name. (Revision 08654048551e30e412dc17d6904c843845337067)
        JENKINS-13035 Only show this option when more than 1 (Revision 026b03104b64189ebdcca2e7d1a869be77f7269d)

        Result = SUCCESS
        ignacio : 08654048551e30e412dc17d6904c843845337067
        Files :

        • core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy

        ignacio : 026b03104b64189ebdcca2e7d1a869be77f7269d
        Files :

        • core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy
        Show
        dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3303 JENKINS-13035 Changed the field name. (Revision 08654048551e30e412dc17d6904c843845337067) JENKINS-13035 Only show this option when more than 1 (Revision 026b03104b64189ebdcca2e7d1a869be77f7269d) Result = SUCCESS ignacio : 08654048551e30e412dc17d6904c843845337067 Files : core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy ignacio : 026b03104b64189ebdcca2e7d1a869be77f7269d Files : core/src/main/resources/hudson/views/MyViewsTabBar/GlobalConfigurationImpl/config.groovy

          People

          • Assignee:
            ialbors Ignacio Albors
            Reporter:
            mdp mdp
          • Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: