Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13073

Clean Workspace Before Each Build fails if Mapping is parametrized

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      1.450
      Perforce version 1.3.7
    • Similar Issues:

      Description

      Mapping setting: //depot/my-project/releases/${RELEASE}/... //my-project-release/...

      Mar 14, 2012 12:17:36 PM hudson.plugins.perforce.PerforceSCM processWorkspaceBeforeDeletion
      SEVERE: null
      com.tek42.perforce.PerforceException: Error in client specification. Error detected at line 9. Null directory (//) not allowed in '//depot/my-project/releases//...'.
      For Command: /usr/bin/p4 -s client -i
      With Data:
      ===================
      Client: my-project-release
      Owner: perforce
      Description: Created by perforce.
      Root: opt/jenkins-data/jobs/my-project-release/workspace
      Options: noallwrite clobber nocompress unlocked nomodtime rmdir
      SubmitOptions: submitunchanged
      LineEnd:
      View:
      //depot/my-project/releases//... //my-project-release/...

      ===================

      at com.tek42.perforce.parse.AbstractPerforceTemplate.saveToPerforce(AbstractPerforceTemplate.java:261)
      at com.tek42.perforce.parse.Workspaces.saveWorkspace(Workspaces.java:69)
      at hudson.plugins.perforce.PerforceSCM.saveWorkspaceIfDirty(PerforceSCM.java:1373)
      at hudson.plugins.perforce.PerforceSCM.processWorkspaceBeforeDeletion(PerforceSCM.java:2353)
      at hudson.plugins.perforce.PerforceSCM.checkout(PerforceSCM.java:575)
      at hudson.model.AbstractProject.checkout(AbstractProject.java:1195)
      at hudson.model.AbstractBuild$AbstractRunner.checkout(AbstractBuild.java:579)
      at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:468)
      at hudson.model.Run.run(Run.java:1408)
      at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:481)
      at hudson.model.ResourceController.execute(ResourceController.java:88)
      at hudson.model.Executor.run(Executor.java:238)

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in plugins_perforce #196
            JENKINS-13073 use build parameters when flushing the workspace during checkout (Revision 9ea05bacb27065a5da74d7f047dad1f64f854569)

            Result = SUCCESS
            Rob Petti :
            Files :

            • src/main/java/hudson/plugins/perforce/PerforceSCM.java
            Show
            dogfood dogfood added a comment - Integrated in plugins_perforce #196 JENKINS-13073 use build parameters when flushing the workspace during checkout (Revision 9ea05bacb27065a5da74d7f047dad1f64f854569) Result = SUCCESS Rob Petti : Files : src/main/java/hudson/plugins/perforce/PerforceSCM.java
            Hide
            rpetti Rob Petti added a comment -

            The s#//#/.../#g approach will probably hurt some users quite a bit. Replacing it with wildcards would make the perforce request too large for a lot of server to handle, so I want to avoid going that route if at all possible. A better option may be to just grab the existing client view from perforce itself, and not change it at all.

            Show
            rpetti Rob Petti added a comment - The s#//#/.../#g approach will probably hurt some users quite a bit. Replacing it with wildcards would make the perforce request too large for a lot of server to handle, so I want to avoid going that route if at all possible. A better option may be to just grab the existing client view from perforce itself, and not change it at all.
            Hide
            jmaxwell Jeff Maxwell added a comment - - edited

            Sounds like a plan.
            We are going to set all our mapping parameters to default to * until the fix is in.

            Show
            jmaxwell Jeff Maxwell added a comment - - edited Sounds like a plan. We are going to set all our mapping parameters to default to * until the fix is in.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Rob Petti
            Path:
            src/main/java/hudson/plugins/perforce/PerforceSCM.java
            http://jenkins-ci.org/commit/perforce-plugin/1d951fc34682abc2cac895196210227e829e6ae2
            Log:
            [FIXED JENKINS-13073] wipeBeforeBuild no longer flushes the client

            flushing the client is kind of a waste of time when wiping out the workspace during a checkout, since we're doing a force-sync immediately after anyways.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/hudson/plugins/perforce/PerforceSCM.java http://jenkins-ci.org/commit/perforce-plugin/1d951fc34682abc2cac895196210227e829e6ae2 Log: [FIXED JENKINS-13073] wipeBeforeBuild no longer flushes the client flushing the client is kind of a waste of time when wiping out the workspace during a checkout, since we're doing a force-sync immediately after anyways.
            Hide
            dogfood dogfood added a comment -

            Integrated in plugins_perforce #197
            [FIXED JENKINS-13073] wipeBeforeBuild no longer flushes the client (Revision 1d951fc34682abc2cac895196210227e829e6ae2)

            Result = SUCCESS
            Rob Petti :
            Files :

            • src/main/java/hudson/plugins/perforce/PerforceSCM.java
            Show
            dogfood dogfood added a comment - Integrated in plugins_perforce #197 [FIXED JENKINS-13073] wipeBeforeBuild no longer flushes the client (Revision 1d951fc34682abc2cac895196210227e829e6ae2) Result = SUCCESS Rob Petti : Files : src/main/java/hudson/plugins/perforce/PerforceSCM.java

              People

              • Assignee:
                rpetti Rob Petti
                Reporter:
                jmaxwell Jeff Maxwell
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: