Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13313

Incorrect warnings about screen density vs resolution appear to be shown

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      While configuring a Galaxy Nexus-like emulator, I got this error message:
      "WXGA800 resolution with density of 320dpi.. are you sure?"

      The resolution WXGA800 is 1280x800, which is similar to the Galaxy Nexus which definitely has a 320dpi screen. I guess the "algorithm" for deciding which densities make sense was possibly not updated when xhdpi was added.

      We should probably also add automated tests for this.

        Attachments

          Activity

          Hide
          orrc Christopher Orr added a comment -

          Without knowing the physical device size, the resolution warning doesn't really make any sense, at least now that Android doesn't just only on phones.

          Show
          orrc Christopher Orr added a comment - Without knowing the physical device size, the resolution warning doesn't really make any sense, at least now that Android doesn't just only on phones.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java
          src/main/java/hudson/plugins/android_emulator/Constants.java
          src/main/resources/hudson/plugins/android_emulator/Messages.properties
          http://jenkins-ci.org/commit/android-emulator-plugin/d9b942b565c062c91d4de57f027d53cb0fbfdfe7
          Log:
          [FIXED JENKINS-13313] Removed warning about suspect screen resolution values.

          This doesn't make so much sense since larger screen sizes like tablets and TVs
          became possible, as we don't know what physical screen size the intended device
          has, so we don't know whether a density/resolution pair makes sense or not.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java src/main/java/hudson/plugins/android_emulator/Constants.java src/main/resources/hudson/plugins/android_emulator/Messages.properties http://jenkins-ci.org/commit/android-emulator-plugin/d9b942b565c062c91d4de57f027d53cb0fbfdfe7 Log: [FIXED JENKINS-13313] Removed warning about suspect screen resolution values. This doesn't make so much sense since larger screen sizes like tablets and TVs became possible, as we don't know what physical screen size the intended device has, so we don't know whether a density/resolution pair makes sense or not.
          Hide
          orrc Christopher Orr added a comment -

          Version 2.11 of the plugin has been released, which fixes this issue.

          Show
          orrc Christopher Orr added a comment - Version 2.11 of the plugin has been released, which fixes this issue.

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              orrc Christopher Orr
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: