Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14660

Plugin doesn't work when using the Nested View plugin

    Details

    • Similar Issues:

      Description

      The Nested View plugin allows to nest your views like this:

      parent view(foo)
      -> child view(bar)

      When using the Wall Display Plugin for the child view, the url parameter 'viewName' becomes "bar", and the Wall Display cannot find the view.
      If you change the parameter to "foo/view/bar" the plugin works as expected.

        Attachments

          Issue Links

            Activity

            Hide
            rodikal Samuel Van Reeth added a comment -
            Show
            rodikal Samuel Van Reeth added a comment - I created a fix for this: https://github.com/jenkinsci/walldisplay-plugin/pull/9
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Samuel Van Reeth
            Path:
            pom.xml
            src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java
            http://jenkins-ci.org/commit/walldisplay-plugin/ec9adea2a382674958eb8fe4ba219b40c25df51a
            Log:
            JENKINS-14660 add support for Nested View plugin

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Samuel Van Reeth Path: pom.xml src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java http://jenkins-ci.org/commit/walldisplay-plugin/ec9adea2a382674958eb8fe4ba219b40c25df51a Log: JENKINS-14660 add support for Nested View plugin
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: pellepelster
            Path:
            pom.xml
            src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java
            http://jenkins-ci.org/commit/walldisplay-plugin/9837a0ff6660ec01d5d10d81c99bddb2732985e3
            Log:
            Merge pull request #9 from rodikal/master

            JENKINS-14660 add support for Nested View plugin

            Compare: https://github.com/jenkinsci/walldisplay-plugin/compare/12b4f555972e...9837a0ff6660

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: pellepelster Path: pom.xml src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java http://jenkins-ci.org/commit/walldisplay-plugin/9837a0ff6660ec01d5d10d81c99bddb2732985e3 Log: Merge pull request #9 from rodikal/master JENKINS-14660 add support for Nested View plugin Compare: https://github.com/jenkinsci/walldisplay-plugin/compare/12b4f555972e...9837a0ff6660
            Show
            mpapo Michael Pailloncy added a comment - This correction seems to have caused an OOME : https://issues.jenkins-ci.org/browse/JENKINS-15482 Furthermore, the while loop seems to be strange : https://github.com/jenkinsci/walldisplay-plugin/blob/master/src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java#L33 isn't it ?
            Hide
            rodikal Samuel Van Reeth added a comment -

            You're correct!
            I fixed the while loop and created a Pull request

            Show
            rodikal Samuel Van Reeth added a comment - You're correct! I fixed the while loop and created a Pull request
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Samuel Van Reeth
            Path:
            src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java
            http://jenkins-ci.org/commit/walldisplay-plugin/737ad3e6c9b4aec9322a245af6ff735d9880a7c3
            Log:
            JENKINS-14660 & JENKINS-15482 fix iteration logic in while loop

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Samuel Van Reeth Path: src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java http://jenkins-ci.org/commit/walldisplay-plugin/737ad3e6c9b4aec9322a245af6ff735d9880a7c3 Log: JENKINS-14660 & JENKINS-15482 fix iteration logic in while loop
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Pelle Pelster
            Path:
            src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java
            http://jenkins-ci.org/commit/walldisplay-plugin/491dbea8dfc14a2269b01c3c90b06ac046d3d72b
            Log:
            Merge pull request #16 from rodikal/master

            JENKINS-15482 JENKINS-14660 fix iteration logic in while loop

            Compare: https://github.com/jenkinsci/walldisplay-plugin/compare/0b6562d8d1a4...491dbea8dfc1

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Pelle Pelster Path: src/main/java/de/pellepelster/jenkins/walldisplay/WallDisplayTransientViewActionFactory.java http://jenkins-ci.org/commit/walldisplay-plugin/491dbea8dfc14a2269b01c3c90b06ac046d3d72b Log: Merge pull request #16 from rodikal/master JENKINS-15482 JENKINS-14660 fix iteration logic in while loop Compare: https://github.com/jenkinsci/walldisplay-plugin/compare/0b6562d8d1a4...491dbea8dfc1

              People

              • Assignee:
                pelle Christian Pelster
                Reporter:
                rodikal Samuel Van Reeth
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: