Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14741

ABI field should be ignored when creating an AVD if not relevant

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently it's not simple to create a matrix job which includes 2.x AVDs as well as 4.x AVDs, since the former don't require an ABI, but the latter do.

      So if you enter the ABI "armeabi-v7a" in the job configuration, this will be used even when trying to generate the 2.x AVDs, which will fail. Conversely, if you don't enter an ABI, the 2.x AVDs will be generated correctly, but the 4.x ones will fail.

      We should not pass the "--abi" flag to "android create avd" if the platform version doesn't support ABIs.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/hudson/plugins/android_emulator/Constants.java
          src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java
          src/main/java/hudson/plugins/android_emulator/SdkInstaller.java
          src/main/java/hudson/plugins/android_emulator/util/Utils.java
          src/test/java/hudson/plugins/android_emulator/AndroidPlatformTest.java
          src/test/java/hudson/plugins/android_emulator/util/UtilsTest.java
          http://jenkins-ci.org/commit/android-emulator-plugin/e8c62cf6cf405d85a84879767a92ee3a09241472
          Log:
          [FIXED JENKINS-14741] Ignore configured ABI when creating emulators which don't support ABIs.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/Constants.java src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java src/main/java/hudson/plugins/android_emulator/SdkInstaller.java src/main/java/hudson/plugins/android_emulator/util/Utils.java src/test/java/hudson/plugins/android_emulator/AndroidPlatformTest.java src/test/java/hudson/plugins/android_emulator/util/UtilsTest.java http://jenkins-ci.org/commit/android-emulator-plugin/e8c62cf6cf405d85a84879767a92ee3a09241472 Log: [FIXED JENKINS-14741] Ignore configured ABI when creating emulators which don't support ABIs. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          orrc Christopher Orr added a comment -

          Version 2.9 has been released, which includes this fix.

          Show
          orrc Christopher Orr added a comment - Version 2.9 has been released, which includes this fix.
          Hide
          stoyboy Stoyan Gaydarov added a comment -

          I am getting NOT_BUILT with this since the 2.3.3 api has multiple abi targets and i believe its being ignored with the fix for this issue, running android list targets has this in it, and as you can see ABIs has multiple entries:

          id: 15 or "android-10"
          Name: Android 2.3.3
          Type: Platform
          API level: 10
          Revision: 2
          Skins: HVGA, QVGA, WQVGA400, WQVGA432, WVGA800 (default), WVGA854
          ABIs : armeabi, x86

          Because of this i get the following error:

          There is more than one system image defined for platform 'android-10'.
          Pick an image to use and set it in the 'Target ABI' config field.
          Valid ABIs: armeabi, x86

          Even though my matrix build actually has armeabi set as the target abi

          Show
          stoyboy Stoyan Gaydarov added a comment - I am getting NOT_BUILT with this since the 2.3.3 api has multiple abi targets and i believe its being ignored with the fix for this issue, running android list targets has this in it, and as you can see ABIs has multiple entries: id: 15 or "android-10" Name: Android 2.3.3 Type: Platform API level: 10 Revision: 2 Skins: HVGA, QVGA, WQVGA400, WQVGA432, WVGA800 (default), WVGA854 ABIs : armeabi, x86 Because of this i get the following error: There is more than one system image defined for platform 'android-10'. Pick an image to use and set it in the 'Target ABI' config field. Valid ABIs: armeabi, x86 Even though my matrix build actually has armeabi set as the target abi
          Hide
          orrc Christopher Orr added a comment -

          Thanks for the info; I'll check it out.

          Show
          orrc Christopher Orr added a comment - Thanks for the info; I'll check it out.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/hudson/plugins/android_emulator/Constants.java
          src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java
          src/main/java/hudson/plugins/android_emulator/SdkInstaller.java
          http://jenkins-ci.org/commit/android-emulator-plugin/485d72b223982e91cc627c02d5ca943ee2eb5345
          Log:
          [FIXED JENKINS-14741] Allow for the x86 ABI for android-10.

          Google now host the x86 ABI for android-10 rather than Intel,
          in the process making it a proper system-image rather than an
          add-on. This caused problems with determining if the configured
          AVD required an ABI, so now we add some more special handling
          for this case.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/Constants.java src/main/java/hudson/plugins/android_emulator/EmulatorConfig.java src/main/java/hudson/plugins/android_emulator/SdkInstaller.java http://jenkins-ci.org/commit/android-emulator-plugin/485d72b223982e91cc627c02d5ca943ee2eb5345 Log: [FIXED JENKINS-14741] Allow for the x86 ABI for android-10. Google now host the x86 ABI for android-10 rather than Intel, in the process making it a proper system-image rather than an add-on. This caused problems with determining if the configured AVD required an ABI, so now we add some more special handling for this case.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/test/java/hudson/plugins/android_emulator/AndroidPlatformTest.java
          http://jenkins-ci.org/commit/android-emulator-plugin/f67c1e2bef2c56ead07636dcd004c0ba5db89b5a
          Log:
          Fix broken test case from JENKINS-14741.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/test/java/hudson/plugins/android_emulator/AndroidPlatformTest.java http://jenkins-ci.org/commit/android-emulator-plugin/f67c1e2bef2c56ead07636dcd004c0ba5db89b5a Log: Fix broken test case from JENKINS-14741 .
          Hide
          orrc Christopher Orr added a comment -

          Version 2.10 of the plugin has been released, which includes this fix.

          Show
          orrc Christopher Orr added a comment - Version 2.10 of the plugin has been released, which includes this fix.

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              orrc Christopher Orr
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: