Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14926

Repo does not implement getAffectedFiles()

    Details

    • Similar Issues:

      Description

      The getAffectedFiles() method in ChangeLogSet.Entry is not being overridden in the repo ChangeLogEntry, leading to the exception that is thrown from here:
      https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/scm/ChangeLogSet.java#L194

      Some plugins use getAffectedFiles() in order to list the changes that triggered a build. For example, the one that is causing builds to fail for us is the HipChat Notifier plugin, which attempts to notify a HipChat room of changes that triggered the build.

      The ChangeLogEntry does collect the list of modified files, but does not return it in the getAffectedFiles() method. The plugin has a getModifiedFiles() method, but does not override the parent class method ChangeLogSet.Entry#getAffectedFiles()

        Attachments

          Activity

          Hide
          jhansche Joe Hansche added a comment -

          Submitted a pull request to fix this: https://github.com/jenkinsci/repo-plugin/pull/8

          Show
          jhansche Joe Hansche added a comment - Submitted a pull request to fix this: https://github.com/jenkinsci/repo-plugin/pull/8
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Joe Hansche
          Path:
          src/main/java/hudson/plugins/repo/ChangeLogEntry.java
          http://jenkins-ci.org/commit/repo-plugin/39dc567cea2bd9b27ff538b11cb4adb4c745e396
          Log:
          [FIXED JENKINS-14926] Implement the parent interface's getAffectedFiles() method.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Joe Hansche Path: src/main/java/hudson/plugins/repo/ChangeLogEntry.java http://jenkins-ci.org/commit/repo-plugin/39dc567cea2bd9b27ff538b11cb4adb4c745e396 Log: [FIXED JENKINS-14926] Implement the parent interface's getAffectedFiles() method.

            People

            • Assignee:
              bklarson bklarson
              Reporter:
              jhansche Joe Hansche
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: