Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15307

Trigger badge images broken when Jenkins is installed at non-root context

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The badge <img> tags assume that Jenkins is installed as the root webapp context. If, as in our case, Jenkins is installed in the non-root context (for example, "jenkins", accessible via http://[host]/jenkins), the images appear broken.

        Attachments

          Activity

          Hide
          batmat Baptiste Mathus added a comment -

          Hi Keith,

          I guess you're deploying Jenkins inside an appserver. For the record, could you tell us which one? That way we might be able to check with your very server version.

          Sorry about that. We'll fix it very soon.

          Cheers

          Show
          batmat Baptiste Mathus added a comment - Hi Keith, I guess you're deploying Jenkins inside an appserver. For the record, could you tell us which one? That way we might be able to check with your very server version. Sorry about that. We'll fix it very soon. Cheers
          Hide
          prospero238 Keith Collison added a comment -

          Tomcat 7, but as you're no doubt aware, would probably happen with any container. As a temporary workaround, I created a small webapp comprised solely of badge images and deployed it to the root context (which is testimony to how handy I think your plugin is!).

          The "Green Ball" plugin had the same defect in its early days. While I doubt the fix is all that complicated, if I'm mistaken, perhaps you can use that as a reference.

          Show
          prospero238 Keith Collison added a comment - Tomcat 7, but as you're no doubt aware, would probably happen with any container. As a temporary workaround, I created a small webapp comprised solely of badge images and deployed it to the root context (which is testimony to how handy I think your plugin is!). The "Green Ball" plugin had the same defect in its early days. While I doubt the fix is all that complicated, if I'm mistaken, perhaps you can use that as a reference.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Baptiste Mathus
          Path:
          src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction/badge.jelly
          http://jenkins-ci.org/commit/buildtriggerbadge-plugin/d0b35b17643a1e6f4da0c4fe3c06dcaa4b748e51
          Log:
          Fix JENKINS-15307 : support jenkins when installed as a non-root context.

          Now the ${rootURL} is prepended to the icon path,
          as it should have been from the start...

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/resources/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction/badge.jelly http://jenkins-ci.org/commit/buildtriggerbadge-plugin/d0b35b17643a1e6f4da0c4fe3c06dcaa4b748e51 Log: Fix JENKINS-15307 : support jenkins when installed as a non-root context. Now the ${rootURL} is prepended to the icon path, as it should have been from the start...
          Hide
          batmat Baptiste Mathus added a comment -

          Ok, just fixed the issue and released a new plugin version.
          For the record, the plugin version containing the fix is the 0.8.

          Thanks a lot for the report and for the comments .
          Cheers

          Show
          batmat Baptiste Mathus added a comment - Ok, just fixed the issue and released a new plugin version. For the record, the plugin version containing the fix is the 0.8. Thanks a lot for the report and for the comments . Cheers
          Hide
          batmat Baptiste Mathus added a comment -

          Hi Keith,
          We you able to test the new 0.8 release. Do you confirm the problem was actually solved by this new version?
          Cheers

          Show
          batmat Baptiste Mathus added a comment - Hi Keith, We you able to test the new 0.8 release. Do you confirm the problem was actually solved by this new version? Cheers

            People

            • Assignee:
              batmat Baptiste Mathus
              Reporter:
              prospero238 Keith Collison
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: