Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15834

It's not possible to specify multiple property files in parametrised trigger

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Due to the correction of JENKINS-8916, where only one type of parameter can be added at a time.
      It's not possible to specify multiple property files anymore.
      See comments in linked issue.

        Attachments

          Issue Links

            Activity

            Hide
            cjo9900 cjo9900 added a comment -

            Caused by changes for this error

            Show
            cjo9900 cjo9900 added a comment - Caused by changes for this error
            Hide
            cjo9900 cjo9900 added a comment -

            Pull request to allow multiple files as a comma separated list.

            https://github.com/jenkinsci/parameterized-trigger-plugin/pull/28

            Show
            cjo9900 cjo9900 added a comment - Pull request to allow multiple files as a comma separated list. https://github.com/jenkinsci/parameterized-trigger-plugin/pull/28
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: cjo9900
            Path:
            src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/config.jelly
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-failTriggerOnMissing.html
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-propertiesFile.html
            src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java
            src/test/resources/hudson/plugins/parameterizedtrigger/test/multiple_property_files.zip
            http://jenkins-ci.org/commit/parameterized-trigger-plugin/d8758e442287caebd244fc5fbbf7d06089aac377
            Log:
            [FIXED JENKINS-15834] Allow multiple properties files

            Support the passing of multiple property files via a
            comma seperated list.
            Correct help messages and add behaviour to correctly
            skip triggering downstream if a file is missing.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: cjo9900 Path: src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-failTriggerOnMissing.html src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-propertiesFile.html src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java src/test/resources/hudson/plugins/parameterizedtrigger/test/multiple_property_files.zip http://jenkins-ci.org/commit/parameterized-trigger-plugin/d8758e442287caebd244fc5fbbf7d06089aac377 Log: [FIXED JENKINS-15834] Allow multiple properties files Support the passing of multiple property files via a comma seperated list. Correct help messages and add behaviour to correctly skip triggering downstream if a file is missing.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: cjo9900
            Path:
            src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/config.jelly
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-failTriggerOnMissing.html
            src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-propertiesFile.html
            src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java
            src/test/resources/hudson/plugins/parameterizedtrigger/test/multiple_property_files.zip
            http://jenkins-ci.org/commit/parameterized-trigger-plugin/51ea12464663e35ebcfa4922efb65f2a64913daf
            Log:
            Merge branch 'JENKINS-15834' of git://github.com/cjo9900/parameterized-trigger-plugin into 2.17-RC

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: cjo9900 Path: src/main/java/hudson/plugins/parameterizedtrigger/FileBuildParameters.java src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-failTriggerOnMissing.html src/main/resources/hudson/plugins/parameterizedtrigger/FileBuildParameters/help-propertiesFile.html src/test/java/hudson/plugins/parameterizedtrigger/test/FileBuildTriggerConfigTest.java src/test/resources/hudson/plugins/parameterizedtrigger/test/multiple_property_files.zip http://jenkins-ci.org/commit/parameterized-trigger-plugin/51ea12464663e35ebcfa4922efb65f2a64913daf Log: Merge branch ' JENKINS-15834 ' of git://github.com/cjo9900/parameterized-trigger-plugin into 2.17-RC
            Hide
            mja Matt Abel added a comment -

            I am seeing this with Parameterized Trigger plugin 2.25 installed on Jenkins 1.596.3.
            If I have 2 files specified then there will be a 'Properties file <filename> did not exist.' message for the second file.

            Show
            mja Matt Abel added a comment - I am seeing this with Parameterized Trigger plugin 2.25 installed on Jenkins 1.596.3. If I have 2 files specified then there will be a 'Properties file <filename> did not exist.' message for the second file.
            Hide
            mja Matt Abel added a comment -

            This seems to be happening because I had a space after the comma. I think it would be good to strip leading/trailing whitespace and make a user explicitly escape the whitespace if they really have it at the front/end of their file names. That's just a personal preference and I would be fine with this being closed without any code changes, but if that is done I think it would be beneficial to add a comment to the help text warning about the use of spaces.

            Show
            mja Matt Abel added a comment - This seems to be happening because I had a space after the comma. I think it would be good to strip leading/trailing whitespace and make a user explicitly escape the whitespace if they really have it at the front/end of their file names. That's just a personal preference and I would be fine with this being closed without any code changes, but if that is done I think it would be beneficial to add a comment to the help text warning about the use of spaces.

              People

              • Assignee:
                cjo9900 cjo9900
                Reporter:
                cjo9900 cjo9900
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: