Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15994

Perforce session ticket is not parsed correctly (again)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Windows XP
    • Similar Issues:

      Description

      The perforce plugin attempts to retrieve the perforce ticket from the second line of the "p4 login -p" command.

      However, the ticket is not always on the second line (On our setup, the second line is "Success: Password verified")

      The bug comes from in http://jenkins-ci.org/commit/perforce-plugin/707d9d2251eec668e0ac1ff816477589471e65c4 for issue JENKINS-15862, which forces the ticket to be parsed from the second line (The previous behavior always used the last line).

      Suggestion: Use the regex "[0-9A-F]

      {32}

      " to find the line containing the perforce ticket

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Rob Petti
            Path:
            src/main/java/com/tek42/perforce/parse/AbstractPerforceTemplate.java
            http://jenkins-ci.org/commit/perforce-plugin/7c747801ad7952ba011226af12a3c6513f96cd17
            Log:
            [FIXED JENKINS-15994] get ticket parsing during login to work when there is custom authentication trigger output

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/com/tek42/perforce/parse/AbstractPerforceTemplate.java http://jenkins-ci.org/commit/perforce-plugin/7c747801ad7952ba011226af12a3c6513f96cd17 Log: [FIXED JENKINS-15994] get ticket parsing during login to work when there is custom authentication trigger output
            Hide
            aflat aflat added a comment -

            Built locally and tested, works great thanks.

            Show
            aflat aflat added a comment - Built locally and tested, works great thanks.

              People

              • Assignee:
                rpetti Rob Petti
                Reporter:
                ldore ldore
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: