Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16160

subversion plugin lose change information

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Duplicate
    • Component/s: subversion-plugin
    • Labels:
      None
    • Environment:
      CENTOS 5.5, CENTOS 6
    • Similar Issues:

      Description

      For example, I have a job and its results are below:
      build5 - successful (change5 in SCM)
      build4 - failed (chaneg4 in SCM)
      build3 - failed (change3 in SCM)
      build2 - failed when code was checkouting from subversion (change2 in SCM)
      build1 - successful (change1 in SCM)

      When I get changeset of build4 or build5 I can see change4 or change5. When I get changeset of build2 I see nothing and it's normal. But build2 didn't create revision.txt and If I get changeset of build3 I expect to see change3 + change2, but I see nothing too. Change2 and change3 dissappeared for jenkins completely.
      I looked to source code of subversion plugin and saw method parseRevisionFile. This method has parameter findClosest.
      All what I need is previousRevisions property assignment with findClosest=true instead of findClosest=false.
      So I've replaced assignment from
      previousRevisions = SubversionSCM.parseRevisionFile(build.getPreviousBuild());
      to
      previousRevisions = SubversionSCM.parseRevisionFile(build.getPreviousBuild(), true, false);
      rebuilt plugin and it's work for me.
      But I have questions: Is it a right way to lose any change information? Why is findClosest=false by default? Are there any problem with findClosest=true? Are there ways for use subversion plugin with findClosest=true without rebuilding plugin?

      Thanks in advance.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/scm/SubversionSCM.java
            http://jenkins-ci.org/commit/subversion-plugin/a0c9c3ab43a8c6d63aea54ff72d88ca08cfc4bc3
            Log:
            [FIXED JENKINS-16160] plugin losing change information if previous build failed during svn checkout

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/SubversionSCM.java http://jenkins-ci.org/commit/subversion-plugin/a0c9c3ab43a8c6d63aea54ff72d88ca08cfc4bc3 Log: [FIXED JENKINS-16160] plugin losing change information if previous build failed during svn checkout

              People

              • Assignee:
                Unassigned
                Reporter:
                ihar_kudrautsau Ihar Kudrautsau
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: