Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16207

"Changes Summary" diff link broken after migration to TFS 2012

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: tfs-plugin
    • Labels:
      None
    • Environment:
      TFS 2012
      TFS Plugin 3.0.1
    • Similar Issues:

      Description

      TFS 2012 changes the URLs of TFS Web Access which is used by the link to the source file in the "Changes Summary Window".

      A link to the source file has changed from:
      https://<tfs-server>/tfs/web/view.aspx?path=<file path>&cs=<change set>
      to:
      https://<tfs-server>/tfs/DefaultCollection/RFQ-hub/_versionControl/item#path=<file path>&cs=<change set>&_a=contents

      A link to the diff has changed from:
      https://<tfs-server>/tfs/web/diff.aspx?opath=<file path>&ocs=<change set>&mpath=<file path>&mcs=<change set>
      to:
      https://<tfs-server>/tfs/DefaultCollection/RFQ-hub/_versionControl/item#cs=<change set>&path=<file path>&opath=<file path>&oversion=<change set>&mpath=<file path>&mversion=<change set>&_a=compare

      TFS seems cable of remapping the link to the file but not to the diff.

        Attachments

          Issue Links

            Activity

            Hide
            domdemaio Dominick DeMaio added a comment - - edited

            Is the GUID an optional feature? I have a fix for the 2012 + URLS that my team has been using for a few months without any issue and it does not include anyhting for that GUID.

            The URL is as follows for me: https://<TFS Server>/tfs/<Collection>/_versionControl/changeset/<Changeset ID>#path=<FULL PATH>&_a=compare

            Show
            domdemaio Dominick DeMaio added a comment - - edited Is the GUID an optional feature? I have a fix for the 2012 + URLS that my team has been using for a few months without any issue and it does not include anyhting for that GUID. The URL is as follows for me: https://<TFS Server>/tfs/<Collection>/_versionControl/changeset/<Changeset ID>#path=<FULL PATH>&_a=compare
            Hide
            koconnor Kyle O'Connor added a comment -

            It looks like you are right, the following is working for me as well with 2012:

            http://<TFS Server>/tfs/<Collection>/_versionControl/changeset?id=<Changeset ID>
            http://<TFS Server>/tfs/<Collection>/_versionControl/changeset/<Changeset ID>#path=<File Path>&_a=compare

            Show
            koconnor Kyle O'Connor added a comment - It looks like you are right, the following is working for me as well with 2012: http://<TFS Server>/tfs/<Collection>/_versionControl/changeset?id=<Changeset ID> http://<TFS Server>/tfs/<Collection>/_versionControl/changeset/<Changeset ID>#path=<File Path>&_a=compare
            Hide
            domdemaio Dominick DeMaio added a comment -

            I submitted a pull request for this today

            Show
            domdemaio Dominick DeMaio added a comment - I submitted a pull request for this today
            Hide
            simpligility Manfred Moser added a comment -

            Here is a PR that fixes this https://github.com/jenkinsci/tfs-plugin/pull/71 by adopting the new pattern.

            Show
            simpligility Manfred Moser added a comment - Here is a PR that fixes this https://github.com/jenkinsci/tfs-plugin/pull/71 by adopting the new pattern.
            Hide
            oli_at_jsi Olivier Dagenais added a comment -

            The fix is in release 4.1.0.

            Show
            oli_at_jsi Olivier Dagenais added a comment - The fix is in release 4.1.0.

              People

              • Assignee:
                robertpi Robert Pickering
                Reporter:
                robertpi Robert Pickering
              • Votes:
                11 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: