Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16264

Posting config.xml to master node advertised to work

    Details

    • Similar Issues:

      Description

      The POST action of config.xml to /computer on 'master' node doesn't work.
      If I go to "/computer/(master)/api" page, it says that the config.xml can be fetched and updated but it doesn't work that way.

      I just took a look at the code and it looks like the "replaceBy(Node newNode)" function on "core/src/main/java/hudson/model/Computer.java" uses the "getNodes()" function defined in "core/src/main/java/jenkins/model/Jenkins.java" which returns only the slaves and NOT the master. Is it an expected behavior? Shouldn't we be able to POST config.xml to master node? It has a lot of options that can be customized and posting the config.xml will help greatly.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
          http://jenkins-ci.org/commit/jenkins/af67ae868e0d150e4d73e48a301c831bc2732b0c
          Log:
          [FIX JENKINS-16264] Don't advertise POSTing config.xml on master

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly http://jenkins-ci.org/commit/jenkins/af67ae868e0d150e4d73e48a301c831bc2732b0c Log: [FIX JENKINS-16264] Don't advertise POSTing config.xml on master
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oliver Gondža
          Path:
          core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
          http://jenkins-ci.org/commit/jenkins/bdfcd2625381e3e9153c1de5ead82abe96ab1c16
          Log:
          Merge pull request #1258 from daniel-beck/JENKINS-16264

          [FIX JENKINS-16264] Don't advertise POSTing config.xml on master

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly http://jenkins-ci.org/commit/jenkins/bdfcd2625381e3e9153c1de5ead82abe96ab1c16 Log: Merge pull request #1258 from daniel-beck/ JENKINS-16264 [FIX JENKINS-16264] Don't advertise POSTing config.xml on master
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3424
          [FIX JENKINS-16264] Don't advertise POSTing config.xml on master (Revision af67ae868e0d150e4d73e48a301c831bc2732b0c)

          Result = SUCCESS
          daniel-beck : af67ae868e0d150e4d73e48a301c831bc2732b0c
          Files :

          • core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3424 [FIX JENKINS-16264] Don't advertise POSTing config.xml on master (Revision af67ae868e0d150e4d73e48a301c831bc2732b0c) Result = SUCCESS daniel-beck : af67ae868e0d150e4d73e48a301c831bc2732b0c Files : core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
          Hide
          danielbeck Daniel Beck added a comment -

          Bot seems to not have picked up the change.

          It's no longer being advertised to work.

          File a feature request if you want to be able to do this.

          Show
          danielbeck Daniel Beck added a comment - Bot seems to not have picked up the change. It's no longer being advertised to work. File a feature request if you want to be able to do this.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly
          http://jenkins-ci.org/commit/jenkins/0a102cddd72f634f6ded56863d6b31befaa4d969
          Log:
          [FIX JENKINS-16264] Don't advertise POSTing config.xml on master

          (cherry picked from commit af67ae868e0d150e4d73e48a301c831bc2732b0c)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/model/Jenkins/MasterComputer/_api.jelly http://jenkins-ci.org/commit/jenkins/0a102cddd72f634f6ded56863d6b31befaa4d969 Log: [FIX JENKINS-16264] Don't advertise POSTing config.xml on master (cherry picked from commit af67ae868e0d150e4d73e48a301c831bc2732b0c)

            People

            • Assignee:
              danielbeck Daniel Beck
              Reporter:
              arangamani Kannan Manickam
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: