Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16453

GitChangeSet.findOrCreateUser does not use correct method when checking for an email address

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
    • Environment:
      Jenkins ver. 1.499
      git plugin: 1.1.26
    • Similar Issues:

      Description

      When checking for an existing email address for a user the proper getAdress() method is not being used:

      GitChangeSet.java, Line 274
      if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null)
      

      should look like:

      if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress())
      

        Attachments

          Activity

          matthias Matthias Richter created issue -
          matthias Matthias Richter made changes -
          Field Original Value New Value
          Description When checking for an existing email address for a user the proper getAdress() method is not being used:

          {code:title=GitChangeSet.java, Line 274|borderStyle=solid}
          if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null)
          {code}

          should look like:

          {code:java
          if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress())
          {code}
          When checking for an existing email address for a user the proper getAdress() method is not being used:

          {code:title=GitChangeSet.java, Line 274|borderStyle=solid}
          if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null)
          {code}

          should look like:

          {code:java}
          if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress())
          {code}
          matthias Matthias Richter made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 147275 ] JNJira + In-Review [ 192313 ]
          markewaite Mark Waite made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              matthias Matthias Richter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: