Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16453

GitChangeSet.findOrCreateUser does not use correct method when checking for an email address

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: git-plugin
    • Labels:
    • Environment:
      Jenkins ver. 1.499
      git plugin: 1.1.26
    • Similar Issues:

      Description

      When checking for an existing email address for a user the proper getAdress() method is not being used:

      GitChangeSet.java, Line 274
      if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null)
      

      should look like:

      if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress())
      

        Attachments

          Activity

          Hide
          matthias Matthias Richter added a comment -

          added a pull request to fix this: https://github.com/jenkinsci/git-plugin/pull/123

          Show
          matthias Matthias Richter added a comment - added a pull request to fix this: https://github.com/jenkinsci/git-plugin/pull/123
          Hide
          matthias Matthias Richter added a comment -

          first proposed pull request was insufficient, added the necessary null checks.

          Show
          matthias Matthias Richter added a comment - first proposed pull request was insufficient, added the necessary null checks.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Matthias Richter
          Path:
          src/main/java/hudson/plugins/git/GitChangeSet.java
          http://jenkins-ci.org/commit/git-plugin/608e6f79b882b26b98d4ee2e0a37f534ce3aee5e
          Log:
          FIXED - JENKINS-16453

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Matthias Richter Path: src/main/java/hudson/plugins/git/GitChangeSet.java http://jenkins-ci.org/commit/git-plugin/608e6f79b882b26b98d4ee2e0a37f534ce3aee5e Log: FIXED - JENKINS-16453
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          src/main/java/hudson/plugins/git/GitChangeSet.java
          src/test/java/hudson/plugins/git/GitChangeSetTest.java
          src/test/java/hudson/plugins/git/TestGitRepo.java
          http://jenkins-ci.org/commit/git-plugin/dcd4f2c1cb21dd0bd7252e9e683df5e45a8a9d98
          Log:
          Merge pull request #123 from richtmat/master

          Fixing JENKINS-16453

          Compare: https://github.com/jenkinsci/git-plugin/compare/a0b969901c8d...dcd4f2c1cb21


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/main/java/hudson/plugins/git/GitChangeSet.java src/test/java/hudson/plugins/git/GitChangeSetTest.java src/test/java/hudson/plugins/git/TestGitRepo.java http://jenkins-ci.org/commit/git-plugin/dcd4f2c1cb21dd0bd7252e9e683df5e45a8a9d98 Log: Merge pull request #123 from richtmat/master Fixing JENKINS-16453 Compare: https://github.com/jenkinsci/git-plugin/compare/a0b969901c8d...dcd4f2c1cb21 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              matthias Matthias Richter
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: