Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16682

DISCOVER-able items break the queue widget

    Details

    • Similar Issues:

      Description

      When the build queue widget renders for an anonymous user, and default view includes some DISCOVER-able jobs, rendering fails with WARNING: Caught exception evaluating: it.queueItems. Reason: java.lang.reflect.InvocationTargetException

      evaluating queueItems, ListView.getItems() iterates on job names and calls getItem(name). This one check for DISCOVER and throws an AccessDeniedException that isn't caught, resulting in some null value passed to jelly.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          core/src/main/java/hudson/model/ListView.java
          http://jenkins-ci.org/commit/jenkins/629b42a309d04cdaea2808d2c1a56560aea062ff
          Log:
          [FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException
          so iterate on itemGroup.getItems and filter by job names


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/ListView.java http://jenkins-ci.org/commit/jenkins/629b42a309d04cdaea2808d2c1a56560aea062ff Log: [FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException so iterate on itemGroup.getItems and filter by job names – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2251
          [FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException (Revision 629b42a309d04cdaea2808d2c1a56560aea062ff)

          Result = UNSTABLE
          Nicolas De Loof : 629b42a309d04cdaea2808d2c1a56560aea062ff
          Files :

          • core/src/main/java/hudson/model/ListView.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2251 [FIXED JENKINS-16682] getItem(name) can throw an AccessDeniedException (Revision 629b42a309d04cdaea2808d2c1a56560aea062ff) Result = UNSTABLE Nicolas De Loof : 629b42a309d04cdaea2808d2c1a56560aea062ff Files : core/src/main/java/hudson/model/ListView.java
          Hide
          jglick Jesse Glick added a comment -

          Another symptom: if a user has only Overall/Read and Job/Discover permissions (but not Job/Read), and directly navigates to a list view containing at least one job (or this view is made the default view), Jenkins shows an error message rather than just displaying the view as empty. Similarly when adding a list view to a nested view: the whole page rendering is broken.

          Show
          jglick Jesse Glick added a comment - Another symptom: if a user has only Overall/Read and Job/Discover permissions (but not Job/Read), and directly navigates to a list view containing at least one job (or this view is made the default view), Jenkins shows an error message rather than just displaying the view as empty. Similarly when adding a list view to a nested view: the whole page rendering is broken.

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              ndeloof Nicolas De Loof
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: