Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17124

ShowDiffs omits some configuration changes

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The ShowDiffs page doesn't show config changes depending on their position regarding other changes in the config.xml. If a changed line in the file follows closely after another changed line, only the first changed line is shown, while the second (although being listed on the showDiffs page) appears with the old value.

      To reproduce:

      • Go to configuration page of a project
      • Change the description as well as the number of days to keep old builds (if these values are empty, you have to repeat that step)
      • Go to the ConfigHistory page of the project
      • Click on "Show Diffs"

      The diff will show the new value only for the description, but the old value for the logRotator entry.
      This also works for entries in other parts of the configuration page as long as the changes are close neighbours in the config.xml.

        Attachments

          Activity

          Hide
          kstutz Kathi Stutz added a comment -

          Fix will be included in next release (probably in April).

          Show
          kstutz Kathi Stutz added a comment - Fix will be included in next release (probably in April).
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kstutz
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryBaseAction.java
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/7137e0367286571f32f7fe81e54a47e315f8882a
          Log:
          Fix showDiffs bug JENKINS-17124

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kstutz Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryBaseAction.java http://jenkins-ci.org/commit/jobConfigHistory-plugin/7137e0367286571f32f7fe81e54a47e315f8882a Log: Fix showDiffs bug JENKINS-17124
          Hide
          kstutz Kathi Stutz added a comment -

          Fix included in version 2.5 (Apr 25 2013).

          Show
          kstutz Kathi Stutz added a comment - Fix included in version 2.5 (Apr 25 2013).
          Hide
          kstutz Kathi Stutz added a comment -

          Version 2.4, actually.

          Show
          kstutz Kathi Stutz added a comment - Version 2.4, actually.

            People

            • Assignee:
              kstutz Kathi Stutz
              Reporter:
              kstutz Kathi Stutz
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: