Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17281

Please add a config option for groupSearchFilter

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ldap-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      There already is a config option for the user search filter. Can you add one for groups?
      This would be more easy than patching groovy files.

        Attachments

          Activity

          Hide
          sbreitbach Steffen Breitbach added a comment -

          +1

          Show
          sbreitbach Steffen Breitbach added a comment - +1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/security/LDAPSecurityRealm.java
          src/main/resources/hudson/security/LDAPSecurityRealm/config.jelly
          src/main/resources/hudson/security/LDAPSecurityRealm/help-cache.html
          src/main/webapp/help-cache.html
          src/main/webapp/help-groupMembershipFilter.html
          src/main/webapp/help-groupSearchFilter.html
          http://jenkins-ci.org/commit/ldap-plugin/50ab44128e55f73dd14d347ea2c890df784a54e4
          Log:
          [FIXES JENKINS-17281] Adding configuration options for the filters used to search for groups.

          • It is somewhat confusing that there are two 'group search filters' so I have decided to rename one.
          • The new name for the 'groupSearchFilter' that is controlled from is the
            as this filter is used to determine what groups a specific user is a member of
          • That leaves as a nice clean name for the filter to search for named groups.
          • This should still respect any existing configuration, i.e. leaving these fields blank will leave the
            existing defaults or existing overrides in place... but it will make life easier for users going forward
          • Took quite some digging to figure out exactly what these filters were for... hopefully I have left things
            in a more obvious framing for anyone else following
          • I would like a better way to apply the override, but this was the cleanest way
            I could maintain backwards compatibility
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/security/LDAPSecurityRealm.java src/main/resources/hudson/security/LDAPSecurityRealm/config.jelly src/main/resources/hudson/security/LDAPSecurityRealm/help-cache.html src/main/webapp/help-cache.html src/main/webapp/help-groupMembershipFilter.html src/main/webapp/help-groupSearchFilter.html http://jenkins-ci.org/commit/ldap-plugin/50ab44128e55f73dd14d347ea2c890df784a54e4 Log: [FIXES JENKINS-17281] Adding configuration options for the filters used to search for groups. It is somewhat confusing that there are two 'group search filters' so I have decided to rename one. The new name for the 'groupSearchFilter' that is controlled from is the as this filter is used to determine what groups a specific user is a member of That leaves as a nice clean name for the filter to search for named groups. This should still respect any existing configuration, i.e. leaving these fields blank will leave the existing defaults or existing overrides in place... but it will make life easier for users going forward Took quite some digging to figure out exactly what these filters were for... hopefully I have left things in a more obvious framing for anyone else following I would like a better way to apply the override, but this was the cleanest way I could maintain backwards compatibility
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/security/LDAPSecurityRealm.java
          src/main/resources/hudson/security/LDAPSecurityRealm/config.jelly
          src/main/resources/hudson/security/LDAPSecurityRealm/help-cache.html
          src/main/webapp/help-cache.html
          src/main/webapp/help-groupMembershipFilter.html
          src/main/webapp/help-groupSearchFilter.html
          http://jenkins-ci.org/commit/ldap-plugin/72a91027abbc544f11020ec8e20d8717451da4d7
          Log:
          [FIXES JENKINS-17281] Adding configuration options for the filters used to search for groups.

          • It is somewhat confusing that there are two `group search filters` so I have decided to rename one.
          • The new name for the `groupSearchFilter` that is controlled from `LDAPBindSecurityRealm.groovy` is the
            `groupMembershipFilter` as this filter is used to determine what groups a specific user is a member of
          • That leaves `groupSearchFilter` as a nice clean name for the filter to search for named groups.
          • This should still respect any existing configuration, i.e. leaving these fields blank will leave the
            existing defaults or existing overrides in place... but it will make life easier for users going forward
          • Took quite some digging to figure out exactly what these filters were for... hopefully I have left things
            in a more obvious framing for anyone else following
          • I would like a better way to apply the `groupMembershipFilter` override, but this was the cleanest way
            I could maintain backwards compatibility
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/security/LDAPSecurityRealm.java src/main/resources/hudson/security/LDAPSecurityRealm/config.jelly src/main/resources/hudson/security/LDAPSecurityRealm/help-cache.html src/main/webapp/help-cache.html src/main/webapp/help-groupMembershipFilter.html src/main/webapp/help-groupSearchFilter.html http://jenkins-ci.org/commit/ldap-plugin/72a91027abbc544f11020ec8e20d8717451da4d7 Log: [FIXES JENKINS-17281] Adding configuration options for the filters used to search for groups. It is somewhat confusing that there are two `group search filters` so I have decided to rename one. The new name for the `groupSearchFilter` that is controlled from `LDAPBindSecurityRealm.groovy` is the `groupMembershipFilter` as this filter is used to determine what groups a specific user is a member of That leaves `groupSearchFilter` as a nice clean name for the filter to search for named groups. This should still respect any existing configuration, i.e. leaving these fields blank will leave the existing defaults or existing overrides in place... but it will make life easier for users going forward Took quite some digging to figure out exactly what these filters were for... hopefully I have left things in a more obvious framing for anyone else following I would like a better way to apply the `groupMembershipFilter` override, but this was the cleanest way I could maintain backwards compatibility
          Hide
          stephenconnolly Stephen Connolly added a comment -

          Fixed in 1.5 release

          Show
          stephenconnolly Stephen Connolly added a comment - Fixed in 1.5 release

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              gruberrolandfiducia Roland Gruber
            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: