Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17419

Added configuration option to disallow bot commands from private chat.

    Details

    • Similar Issues:

      Description

      JENKINS-5931 want to restrict some user to access the commands, and JENKINS-11606 disable the commands in channel room.
      But ircbot still allow unauthorized access by private chat.
      (The "/msg ircbot ircbot: help" or "/msg ircbot !prefixCommand help" messages can control ircbot.)

      After added "disallow private chat commands" option, we can control the usage of commands to a specific group of users.
      ex:
      > Channels:
      > - channel-notification / no password / enable "Notification only"
      > - channel-admin / has password / disable "Notification only"
      > Enable "Disallow Private Chat"

      Unauthorized users join channel-notification to get irc notifications, the authorized users join channel-admin to control the jenkins by commands.
      And other unauthorized users cannot control jenkins by private chat.

        Attachments

          Issue Links

            Activity

            askeing Askeing created issue -
            askeing Askeing made changes -
            Field Original Value New Value
            Link This issue depends on JENKINS-11606 [ JENKINS-11606 ]
            askeing Askeing made changes -
            Link This issue depends on JENKINS-5931 [ JENKINS-5931 ]
            askeing Askeing made changes -
            Link This issue depends on JENKINS-11606 [ JENKINS-11606 ]
            askeing Askeing made changes -
            Link This issue depends on JENKINS-5931 [ JENKINS-5931 ]
            askeing Askeing made changes -
            Link This issue is related to JENKINS-5931 [ JENKINS-5931 ]
            askeing Askeing made changes -
            Link This issue is related to JENKINS-11606 [ JENKINS-11606 ]
            Show
            askeing Askeing added a comment - http://jenkins-ci.org/commit/ircbot-plugin/7d853dbdb1b6adbadeb752ed568863d92ec99044
            kutzi kutzi made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/plugins/ircbot/IrcPublisher.java
            src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
            src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly
            http://jenkins-ci.org/commit/ircbot-plugin/15141254748d8bfb074a0978afde1d15ccad92af
            Log:
            Merge pull request #6 from askeing/disallowPrivateChatCommands

            JENKINS-17419 Added new configuration option to disallow bot commands from private chat.

            Compare: https://github.com/jenkinsci/ircbot-plugin/compare/323ab68fc572...15141254748d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/ircbot/IrcPublisher.java src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly http://jenkins-ci.org/commit/ircbot-plugin/15141254748d8bfb074a0978afde1d15ccad92af Log: Merge pull request #6 from askeing/disallowPrivateChatCommands JENKINS-17419 Added new configuration option to disallow bot commands from private chat. Compare: https://github.com/jenkinsci/ircbot-plugin/compare/323ab68fc572...15141254748d
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 148254 ] JNJira + In-Review [ 192790 ]

              People

              • Assignee:
                askeing Askeing
                Reporter:
                askeing Askeing
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: