Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17816

SDK lookup from PATH looks for adb in {sdk}/tools folder (it has been moved).

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Utils.getSdkRootFromPath() is testing for the existence of adb AND emulator in each directory in the path to determine if it is the Android SDK tools directory. The problem with this is is that in newer versions of the Android SDK, adb has been moved to the platform-tools directory. It will never find adb inside the same directory emulator is.

      I suggest adding a check for adb_has_moved.txt if you must use the tools directory to determine the availability of the SDK in the PATH.

        Attachments

          Activity

          Hide
          mikedougherty Mike Dougherty added a comment - - edited

          I'm also experiencing this after our Android SDK was updated. The component is now unable to detect the installed SDK, causing it to attempt automatic install, which fails as it is unable to accept the license correctly (and even if it succeeded, I assume the tools would not be detected correctly).

          Show
          mikedougherty Mike Dougherty added a comment - - edited I'm also experiencing this after our Android SDK was updated. The component is now unable to detect the installed SDK, causing it to attempt automatic install, which fails as it is unable to accept the license correctly (and even if it succeeded, I assume the tools would not be detected correctly).
          Hide
          raphaeloliveira Raphael Oliveira added a comment -
          Show
          raphaeloliveira Raphael Oliveira added a comment - Having the same problem here. Question @ stack overflow: http://stackoverflow.com/questions/16614073/android-emulator-plugin-doesnt-find-the-android-sdk
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/hudson/plugins/android_emulator/util/Utils.java
          http://jenkins-ci.org/commit/android-emulator-plugin/dc6e2ca7eacbe4809f39cdf82b69de9510a57880
          Log:
          [FIXED JENKINS-17816] Fix detection of SDK from PATH.

          Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/485d72b22398...dc6e2ca7eacb

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/util/Utils.java http://jenkins-ci.org/commit/android-emulator-plugin/dc6e2ca7eacbe4809f39cdf82b69de9510a57880 Log: [FIXED JENKINS-17816] Fix detection of SDK from PATH. Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/485d72b22398...dc6e2ca7eacb
          Hide
          mikedougherty Mike Dougherty added a comment -

          I'm working on testing this fix now.

          Show
          mikedougherty Mike Dougherty added a comment - I'm working on testing this fix now.
          Hide
          raphaeloliveira Raphael Oliveira added a comment -

          Mike Dougherty I think it is already resolved. See comment above.

          Show
          raphaeloliveira Raphael Oliveira added a comment - Mike Dougherty I think it is already resolved. See comment above.
          Hide
          mikedougherty Mike Dougherty added a comment -

          Yep - I'm building Christopher's fix and testing locally

          Show
          mikedougherty Mike Dougherty added a comment - Yep - I'm building Christopher's fix and testing locally
          Hide
          orrc Christopher Orr added a comment -

          Version 2.10 of the plugin has been released, which includes this fix.

          Show
          orrc Christopher Orr added a comment - Version 2.10 of the plugin has been released, which includes this fix.

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              austynmahoney AM
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: