Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18410

Use RunAction2 from TestResultAction

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      To prevent lazy-loading issues.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java
            core/src/main/java/hudson/tasks/junit/TestResultAction.java
            core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
            core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
            core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
            core/src/main/java/hudson/tasks/test/MatrixTestResult.java
            core/src/main/java/hudson/tasks/test/TestResultAggregator.java
            test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
            test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java
            http://jenkins-ci.org/commit/jenkins/b53770c70f53084bb98e61985a6a9ba0bebdeb75
            Log:
            [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build.
            (cherry picked from commit fcdf74991226fb6869052caa89ed8d678944b6fc)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java core/src/main/java/hudson/tasks/test/TestResultAggregator.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java test/src/test/java/hudson/tasks/test/TrivialTestResultRecorder.java http://jenkins-ci.org/commit/jenkins/b53770c70f53084bb98e61985a6a9ba0bebdeb75 Log: [FIXED JENKINS-18410] AbstractTestResultAction should be a RunAction2 so it need not persist its owning build. (cherry picked from commit fcdf74991226fb6869052caa89ed8d678944b6fc) Conflicts: changelog.html
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java
            test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
            http://jenkins-ci.org/commit/jenkins/b5ec39f0734d05f1de05406a2dddc0bed4440d60
            Log:
            JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising.
            java.lang.NullPointerException
            at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173)
            at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146)
            at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135)
            at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90)

            (cherry picked from commit bfaab5118d079405b82b80301d90e19f39970366)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/test/AggregatedTestResultPublisher.java test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java http://jenkins-ci.org/commit/jenkins/b5ec39f0734d05f1de05406a2dddc0bed4440d60 Log: JENKINS-18410 NPE from previous fix (fcdf749) under some conditions, which the test case was not exercising. java.lang.NullPointerException at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.getProject(AggregatedTestResultPublisher.java:173) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:146) at hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction.<init>(AggregatedTestResultPublisher.java:135) at hudson.tasks.test.AggregatedTestResultPublisher.perform(AggregatedTestResultPublisher.java:90) (cherry picked from commit bfaab5118d079405b82b80301d90e19f39970366) Conflicts: changelog.html
            Hide
            thedj Derk-Jan Hartman added a comment -

            The fix to the fix didn't make it to 1.546 it seems, causing both 1.545 and 1.546 to fail jobs in the aggregate test results phase with the NPE listed in the previous comments.

            The workaround for this is to explicitly set the names of the jobs that you want aggregated in your job configuration or to remove the entire aggregate task from the job.

            Show
            thedj Derk-Jan Hartman added a comment - The fix to the fix didn't make it to 1.546 it seems, causing both 1.545 and 1.546 to fail jobs in the aggregate test results phase with the NPE listed in the previous comments. The workaround for this is to explicitly set the names of the jobs that you want aggregated in your job configuration or to remove the entire aggregate task from the job.
            Hide
            jglick Jesse Glick added a comment -

            Correct, the fix should be in 1.547, and the workaround is to set names explicitly. Sorry for any disruption.

            Show
            jglick Jesse Glick added a comment - Correct, the fix should be in 1.547, and the workaround is to set names explicitly. Sorry for any disruption.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/tasks/junit/TestResultAction.java
            core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java
            core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java
            core/src/main/java/hudson/tasks/test/MatrixTestResult.java
            test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java
            http://jenkins-ci.org/commit/jenkins/412befcb57d520bb1a5a737329785405c8f2c828
            Log:
            JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh).

            (cherry picked from commit 2a2a7eb8ed29714961fd145a6186db4aef9d63ba)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/tasks/junit/TestResultAction.java core/src/main/java/hudson/tasks/test/AbstractTestResultAction.java core/src/main/java/hudson/tasks/test/AggregatedTestResultAction.java core/src/main/java/hudson/tasks/test/MatrixTestResult.java test/src/test/java/hudson/tasks/test/TrivialTestResultAction.java http://jenkins-ci.org/commit/jenkins/412befcb57d520bb1a5a737329785405c8f2c828 Log: JENKINS-20951 JENKINS-18410 Did not make it into 1.544 due to validated merge holdups (mostly randomly failing tests, sigh). (cherry picked from commit 2a2a7eb8ed29714961fd145a6186db4aef9d63ba) Conflicts: changelog.html

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: