Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18417

Clean up fingerprint records that correspond to the deleted build recods

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      FingerprintCleanupThread currently either deletes the whole record (when none of the information in the record is in use anywhere at all) or not touch it at all.

      This means that some fingerprints (such as one for maven-compiler-plugin that every Maven build likely uses) will remain there forever with lots of build records and jobs that are long gone.

      The garbage collection algorithm should probably be more aggressive and remove references to builds and jobs that no longer exist when it can.

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2637
            [FIXED JENKINS-18417] (Revision 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24)

            Result = UNSTABLE
            kohsuke : 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24
            Files :

            • test/src/test/java/hudson/tasks/FingerprinterTest.java
            • changelog.html
            • core/src/test/java/hudson/model/FingerprintTest.java
            • core/src/main/java/hudson/tasks/Fingerprinter.java
            • core/src/main/java/hudson/model/FingerprintCleanupThread.java
            • core/src/main/java/hudson/model/Fingerprint.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2637 [FIXED JENKINS-18417] (Revision 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24) Result = UNSTABLE kohsuke : 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24 Files : test/src/test/java/hudson/tasks/FingerprinterTest.java changelog.html core/src/test/java/hudson/model/FingerprintTest.java core/src/main/java/hudson/tasks/Fingerprinter.java core/src/main/java/hudson/model/FingerprintCleanupThread.java core/src/main/java/hudson/model/Fingerprint.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/model/Fingerprint.java
            core/src/main/java/hudson/model/FingerprintCleanupThread.java
            core/src/main/java/hudson/tasks/Fingerprinter.java
            core/src/test/java/hudson/model/FingerprintTest.java
            test/src/test/java/hudson/tasks/FingerprinterTest.java
            http://jenkins-ci.org/commit/jenkins/216f5c6a45ed4f5e592817ed6192d5b5fc1dee24
            Log:
            [FIXED JENKINS-18417]

            FingerprintCleanupThread can now partially clean up a fingerprint record
            by removing portions of it that's not referencing existing stuff.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/Fingerprint.java core/src/main/java/hudson/model/FingerprintCleanupThread.java core/src/main/java/hudson/tasks/Fingerprinter.java core/src/test/java/hudson/model/FingerprintTest.java test/src/test/java/hudson/tasks/FingerprinterTest.java http://jenkins-ci.org/commit/jenkins/216f5c6a45ed4f5e592817ed6192d5b5fc1dee24 Log: [FIXED JENKINS-18417] FingerprintCleanupThread can now partially clean up a fingerprint record by removing portions of it that's not referencing existing stuff.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/src/main/java/hudson/model/Fingerprint.java
            core/src/main/java/hudson/model/FingerprintCleanupThread.java
            core/src/main/java/hudson/tasks/Fingerprinter.java
            core/src/test/java/hudson/model/FingerprintTest.java
            test/src/test/java/hudson/tasks/FingerprinterTest.java
            http://jenkins-ci.org/commit/jenkins/f5c9bafe892ce1726a51e069892e5e81080ebe8b
            Log:
            [FIXED JENKINS-18417]

            FingerprintCleanupThread can now partially clean up a fingerprint record
            by removing portions of it that's not referencing existing stuff.

            (cherry picked from commit 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/model/Fingerprint.java core/src/main/java/hudson/model/FingerprintCleanupThread.java core/src/main/java/hudson/tasks/Fingerprinter.java core/src/test/java/hudson/model/FingerprintTest.java test/src/test/java/hudson/tasks/FingerprinterTest.java http://jenkins-ci.org/commit/jenkins/f5c9bafe892ce1726a51e069892e5e81080ebe8b Log: [FIXED JENKINS-18417] FingerprintCleanupThread can now partially clean up a fingerprint record by removing portions of it that's not referencing existing stuff. (cherry picked from commit 216f5c6a45ed4f5e592817ed6192d5b5fc1dee24) Conflicts: changelog.html

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: