Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18455

all modules of all maven projects are listed separately

    Details

    • Similar Issues:

      Description

      From 1.36 to 1.37 something changed so we now see all modules of all our maven projects as separately configurable in configuration slicing.
      Due to the number of projects and the huge number of modules within each of them, configuration slicing lost much of its usability.

      Maybe the noted change "add support for folders" brought this change.

      Would be nice to have a global config switch to set configuration slicing to default to the old behaviour no longer showing every single maven module in config slicing lists when not explicitely chosen to do so.

      Reverting to 1.36 from 1.37 brought back the old behaviour for us so we can see again our projects without every single maven module listed besides them.

        Attachments

          Issue Links

            Activity

            Show
            danielbeck Daniel Beck added a comment - Fairly obvious left overs from https://github.com/jenkinsci/configurationslicing-plugin/commit/cfcd3d0f6aec34035e773d656d1991aa45a8061c – The fix in https://github.com/jenkinsci/configurationslicing-plugin/commit/eefdd378edd33db54ec7e2abcddbc63ca7428fec only took care of Maven Version.
            Hide
            ninian Ninian added a comment -
            Show
            ninian Ninian added a comment - I've added a pull request to fix this: https://github.com/jenkinsci/configurationslicing-plugin/pull/11
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ninian
            Path:
            src/main/java/configurationslicing/TopLevelItemSelector.java
            src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java
            src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java
            src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java
            src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java
            src/main/java/configurationslicing/claim/ClaimSlicer.java
            src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java
            src/main/java/configurationslicing/jdk/JdkSlicer.java
            src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java
            src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java
            src/main/java/configurationslicing/label/LabelSlicer.java
            src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java
            src/main/java/configurationslicing/logrotator/LogRotationSlicer.java
            src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java
            src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
            src/main/java/configurationslicing/timestamper/TimestamperSlicer.java
            src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java
            http://jenkins-ci.org/commit/configurationslicing-plugin/c9a8c001a20fcd57d9f86adcd121bbb3801cdbdc
            Log:
            JENKINS-18455: Exclude items other than top level projects from slicing

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/configurationslicing/TopLevelItemSelector.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java src/main/java/configurationslicing/claim/ClaimSlicer.java src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java src/main/java/configurationslicing/jdk/JdkSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java src/main/java/configurationslicing/label/LabelSlicer.java src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java src/main/java/configurationslicing/logrotator/LogRotationSlicer.java src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java src/main/java/configurationslicing/timestamper/TimestamperSlicer.java src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java http://jenkins-ci.org/commit/configurationslicing-plugin/c9a8c001a20fcd57d9f86adcd121bbb3801cdbdc Log: JENKINS-18455 : Exclude items other than top level projects from slicing
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ninian
            Path:
            src/main/java/configurationslicing/TopLevelItemSelector.java
            src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java
            src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java
            src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java
            src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java
            src/main/java/configurationslicing/claim/ClaimSlicer.java
            src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java
            src/main/java/configurationslicing/jdk/JdkSlicer.java
            src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java
            src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java
            src/main/java/configurationslicing/label/LabelSlicer.java
            src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java
            src/main/java/configurationslicing/logrotator/LogRotationSlicer.java
            src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java
            src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java
            src/main/java/configurationslicing/timestamper/TimestamperSlicer.java
            src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java
            http://jenkins-ci.org/commit/configurationslicing-plugin/f78127ed04eebe1af465af0fd71831269526b4a5
            Log:
            Merge pull request #11 from ninian/master

            FIXED JENKINS-18455 - remove extra maven modules from all slicing
            FIXED JENKINS-20082
            FIXED JENKINS-21556
            FIXED JENKINS-23766

            Compare: https://github.com/jenkinsci/configurationslicing-plugin/compare/9434d1dfe7e8...f78127ed04ee

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/configurationslicing/TopLevelItemSelector.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenDownstreamBuildingBoolSlicer.java src/main/java/configurationslicing/blockbuild/BlockBuildWhenUpstreamBuildingBoolSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer.java src/main/java/configurationslicing/buildtimeout/BuildTimeoutSlicer2.java src/main/java/configurationslicing/claim/ClaimSlicer.java src/main/java/configurationslicing/email/AbstractEmailSliceSpec.java src/main/java/configurationslicing/jdk/JdkSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledBoolSlicer.java src/main/java/configurationslicing/jobdisabled/JobDisabledStringSlicer.java src/main/java/configurationslicing/label/LabelSlicer.java src/main/java/configurationslicing/logfilesizechecker/LogfilesizecheckerSlicer.java src/main/java/configurationslicing/logrotator/LogRotationSlicer.java src/main/java/configurationslicing/prioritysorter/PrioritySorterSlicer.java src/main/java/configurationslicing/timer/AbstractTimerSliceSpec.java src/main/java/configurationslicing/timestamper/TimestamperSlicer.java src/main/java/configurationslicing/tools/AbstractToolSlicerSpec.java http://jenkins-ci.org/commit/configurationslicing-plugin/f78127ed04eebe1af465af0fd71831269526b4a5 Log: Merge pull request #11 from ninian/master FIXED JENKINS-18455 - remove extra maven modules from all slicing FIXED JENKINS-20082 FIXED JENKINS-21556 FIXED JENKINS-23766 Compare: https://github.com/jenkinsci/configurationslicing-plugin/compare/9434d1dfe7e8...f78127ed04ee
            Hide
            ninian Ninian added a comment -

            Should be fixed in version 1.40 of the plugin.

            Show
            ninian Ninian added a comment - Should be fixed in version 1.40 of the plugin.

              People

              • Assignee:
                ninian Ninian
                Reporter:
                tcb T.-C. B.
              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: