XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The following two threads cause a dead lock:

      	at hudson.model.AbstractProject.save(AbstractProject.java:268)
      	-  blocked on hudson.maven.MavenModuleSet@57164bd1
      	at hudson.plugins.copyartifact.CopyArtifact$ListenerImpl.onRenamed(CopyArtifact.java:331)
      	at hudson.model.AbstractItem.renameTo(AbstractItem.java:296)
      	-  locked hudson.model.FreeStyleProject@29a74e2b
      	-  locked com.cloudbees.hudson.plugins.folder.Folder@29a1da29
      	at hudson.model.Job.renameTo(Job.java:577)
      	at hudson.model.Job.doDoRename(Job.java:1311)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:601)
      	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:288)
      	at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:29)
      	at org.kohsuke.stapler.Function$InterceptedFunction.invoke(Function.java:389)
      
      	at hudson.model.Project.getPublishersList(Project.java:114)
      	-  blocked on hudson.model.FreeStyleProject@29a74e2b
      	at hudson.model.Project.buildDependencyGraph(Project.java:172)
      	at hudson.model.DependencyGraph.build(DependencyGraph.java:90)
      	at jenkins.model.Jenkins.rebuildDependencyGraph(Jenkins.java:3563)
      	at hudson.model.AbstractItem.delete(AbstractItem.java:515)
      	-  locked hudson.maven.MavenModuleSet@57164bd1
      	at hudson.model.Job.delete(Job.java:587)
      	-  locked hudson.maven.MavenModuleSet@57164bd1
      	at com.cloudbees.hudson.plugins.folder.Folder.performDelete(Folder.java:505)
      	at hudson.model.AbstractItem.delete(AbstractItem.java:507)
      	-  locked com.cloudbees.hudson.plugins.folder.Folder@44bf68c1
      	at hudson.model.AbstractItem.doDoDelete(AbstractItem.java:484)
      

        Attachments

          Issue Links

            Activity

            Hide
            dmatag dmatag added a comment -

            This solution (https://github.com/jenkinsci/jenkins/commit/7facc7733c7040536d4074a2c5805b75ee1d8f35) causes UnsupportedOperationException from AbstractProject.removeTrigger and addTrigger. DescribableList is AbstractList and we cannot modify them. Do you have any workaround to solve it?

            Show
            dmatag dmatag added a comment - This solution ( https://github.com/jenkinsci/jenkins/commit/7facc7733c7040536d4074a2c5805b75ee1d8f35 ) causes UnsupportedOperationException from AbstractProject.removeTrigger and addTrigger. DescribableList is AbstractList and we cannot modify them. Do you have any workaround to solve it?
            Hide
            jglick Jesse Glick added a comment -

            Cannot be backported without also including fix for JENKINS-18677.

            Show
            jglick Jesse Glick added a comment - Cannot be backported without also including fix for JENKINS-18677 .
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/matrix/MatrixProject.java
            core/src/main/java/hudson/model/AbstractProject.java
            core/src/main/java/hudson/model/Project.java
            maven-plugin/src/main/java/hudson/maven/AbstractMavenProject.java
            test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
            test/src/test/resources/hudson/model/AbstractProjectTest/vectorTriggers.xml
            http://jenkins-ci.org/commit/jenkins/5407d9fbce6b10d6902f0cc5971ee95c71619f3a
            Log:
            [FIXED JENKINS-18589]

            Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice.

            This change has the nice side effect of removing class="vector" from the persisted XML. A test is added to make sure we can still read back such an XML.

            (cherry picked from commit 7facc7733c7040536d4074a2c5805b75ee1d8f35)

            Conflicts:
            test/src/test/groovy/hudson/model/AbstractProjectTest.groovy

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/matrix/MatrixProject.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Project.java maven-plugin/src/main/java/hudson/maven/AbstractMavenProject.java test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/resources/hudson/model/AbstractProjectTest/vectorTriggers.xml http://jenkins-ci.org/commit/jenkins/5407d9fbce6b10d6902f0cc5971ee95c71619f3a Log: [FIXED JENKINS-18589] Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice. This change has the nice side effect of removing class="vector" from the persisted XML. A test is added to make sure we can still read back such an XML. (cherry picked from commit 7facc7733c7040536d4074a2c5805b75ee1d8f35) Conflicts: test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            test/src/test/java/hudson/triggers/TriggerStartTest.java
            http://jenkins-ci.org/commit/jenkins/f9e176a5baa5baa85d0e9bb8f8bd23bc47272fd2
            Log:
            JENKINS-18589 Updatign tests

            (cherry picked from commit 87851d176503123ba35ffe22c5a56322d9c2b352)

            Compare: https://github.com/jenkinsci/jenkins/compare/a021fe5c2422...f9e176a5baa5

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: test/src/test/java/hudson/triggers/TriggerStartTest.java http://jenkins-ci.org/commit/jenkins/f9e176a5baa5baa85d0e9bb8f8bd23bc47272fd2 Log: JENKINS-18589 Updatign tests (cherry picked from commit 87851d176503123ba35ffe22c5a56322d9c2b352) Compare: https://github.com/jenkinsci/jenkins/compare/a021fe5c2422...f9e176a5baa5
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            src/main/java/hudson/maven/AbstractMavenProject.java
            http://jenkins-ci.org/commit/maven-plugin/a779e6769320d88abc905a454f2fe7f45f5ed5f0
            Log:
            [FIXED JENKINS-18589]

            Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice.

            This change has the nice side effect of removing class="vector" from the persisted XML. A test is added to make sure we can still read back such an XML.

            Originally-Committed-As: 7facc7733c7040536d4074a2c5805b75ee1d8f35

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/main/java/hudson/maven/AbstractMavenProject.java http://jenkins-ci.org/commit/maven-plugin/a779e6769320d88abc905a454f2fe7f45f5ed5f0 Log: [FIXED JENKINS-18589] Use DescribableList to handle the copy-on-write semantics correctly. The vector class just doesn't cut it, and we've been setting a new value to this field, which will violates all sorts of the concurrent programming practice. This change has the nice side effect of removing class="vector" from the persisted XML. A test is added to make sure we can still read back such an XML. Originally-Committed-As: 7facc7733c7040536d4074a2c5805b75ee1d8f35

              People

              • Assignee:
                kohsuke Kohsuke Kawaguchi
                Reporter:
                kohsuke Kohsuke Kawaguchi
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: