Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18641

People View does Not Populate (makeStaplerProxy)

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Environment:
      Windows Server 2008, Debian 7, Ubuntu 12.04, CentOS 6.4
    • Similar Issues:

      Description

      On entering the "People" view on Jenkins, some page elements load while the list of people is not. Instead a message displays along the lines of:

      makeStaplerProxy('/jenkins/$stapler/bound/7544a1d9-a6f5-44ea-8a6f-ccfd839f03e9','65215ee9-8e24-4f45-96b9-4e34a01b79cf',['news']), display);

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            The same bug applies to other users of <st:bind>. @rsandell suggests adding to layout.jelly:

            <st:adjunct assumes="org.kohsuke.stapler.framework.prototype.prototype"
                            includes="org.kohsuke.stapler.json2"/>
            

            right after the existing include of org.kohsuke.stapler.bind. Needs to be tested for effectiveness (after reverting the original fix of this issue).

            Show
            jglick Jesse Glick added a comment - The same bug applies to other users of <st:bind> . @rsandell suggests adding to layout.jelly : <st:adjunct assumes= "org.kohsuke.stapler.framework.prototype.prototype" includes= "org.kohsuke.stapler.json2" /> right after the existing include of org.kohsuke.stapler.bind . Needs to be tested for effectiveness (after reverting the original fix of this issue).
            Hide
            kohsuke Kohsuke Kawaguchi added a comment -

            Actually, I think BindTag's inclusion logic is wrong.

            The idea is that we need either prototype or JQuery for <st:bind> to work correctly.

            If the current page already includes Prototype, there's no need to have "org.kohsuke.stapler.json2" adjunct, as we don't use JSON.stringify()

            In Jenkins, every page automatically gets prototype, so there's never a need for this inclusion.

            I'm going to fix this by tweaking BindTag.java.

            A test can be written by simulating an insertion of jQuery adjunct into the page, so it should be testable.

            Show
            kohsuke Kohsuke Kawaguchi added a comment - Actually, I think BindTag's inclusion logic is wrong. The idea is that we need either prototype or JQuery for <st:bind> to work correctly. If the current page already includes Prototype, there's no need to have "org.kohsuke.stapler.json2" adjunct, as we don't use JSON.stringify() In Jenkins, every page automatically gets prototype, so there's never a need for this inclusion. I'm going to fix this by tweaking BindTag.java. A test can be written by simulating an insertion of jQuery adjunct into the page, so it should be testable.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            core/pom.xml
            http://jenkins-ci.org/commit/jenkins/7e8bbea3336dc65a10c2fd69a20beac20bc6fca3
            Log:
            [FIXED JENKINS-18641]

            Eliminated the wrong script tag generation from <st:bind/>

            Compare: https://github.com/jenkinsci/jenkins/compare/738a1d116409...7e8bbea3336d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/pom.xml http://jenkins-ci.org/commit/jenkins/7e8bbea3336dc65a10c2fd69a20beac20bc6fca3 Log: [FIXED JENKINS-18641] Eliminated the wrong script tag generation from <st:bind/> Compare: https://github.com/jenkinsci/jenkins/compare/738a1d116409...7e8bbea3336d
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2795

            Result = UNSTABLE

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2795 Result = UNSTABLE
            Hide
            zfil Philippe Jandot added a comment -

            Stapler 1.217 cause some regressions JENKINS-19281 and JENKINS-19168

            Show
            zfil Philippe Jandot added a comment - Stapler 1.217 cause some regressions JENKINS-19281 and JENKINS-19168

              People

              • Assignee:
                sogabe sogabe
                Reporter:
                zulu12 Wilfredo Velazquez
              • Votes:
                8 Vote for this issue
                Watchers:
                18 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: