Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18889

BuildResultTrigger should not need to check for available nodes

    Details

    • Similar Issues:

      Description

      Using BuildResultTrigger 0.12.

      I have several nodes that are only used for certain jobs. These nodes are started when needed and are taken off line when not used. The BRT plugin looks for a node it can run on, but this makes no sense in my case. I have to have two projects set up. One to run on the master jenkins node to run the BRT, which then schedules the real build. (Which in turn causes Jenkins to start the needed node.) I would much prefer to use only one project.

        Attachments

          Activity

          Hide
          gbois Gregory Boissinot added a comment -

          The polling should be executed only on master for this plugin.
          You're right, we don't have to delegate to nodes for this use case.

          Show
          gbois Gregory Boissinot added a comment - The polling should be executed only on master for this plugin. You're right, we don't have to delegate to nodes for this use case.
          Hide
          gbois Gregory Boissinot added a comment -

          But maybe we need to take in consideration, Jenkins instances where the number of executors is set to 0.

          Show
          gbois Gregory Boissinot added a comment - But maybe we need to take in consideration, Jenkins instances where the number of executors is set to 0.
          Hide
          tparent Tony Parent added a comment -

          In the case of zero executors, then yes, you will probably need to search for an available executor. Any other time it should not matter. (And really you don't need an executor to do the poll of the previous job's status. Seeing as you are only storing it in memory anyway, it really doesn't make much sense to run this anywhere but on the master...)

          Show
          tparent Tony Parent added a comment - In the case of zero executors, then yes, you will probably need to search for an available executor. Any other time it should not matter. (And really you don't need an executor to do the poll of the previous job's status. Seeing as you are only storing it in memory anyway, it really doesn't make much sense to run this anywhere but on the master...)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/org/jenkinsci/lib/xtrigger/AbstractTrigger.java
          src/main/java/org/jenkinsci/lib/xtrigger/AbstractTriggerByFullContext.java
          http://jenkins-ci.org/commit/xtrigger-lib/f35d4f8a610eefafc3fc99925b6b1c304f5367d2
          Log:
          Add functionality: Enable to not require a polling node.
          Fix JENKINS-18889

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/lib/xtrigger/AbstractTrigger.java src/main/java/org/jenkinsci/lib/xtrigger/AbstractTriggerByFullContext.java http://jenkins-ci.org/commit/xtrigger-lib/f35d4f8a610eefafc3fc99925b6b1c304f5367d2 Log: Add functionality: Enable to not require a polling node. Fix JENKINS-18889
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java
          http://jenkins-ci.org/commit/buildresult-trigger-plugin/e3e29b92c57f57a120cc0afa3a7da13b844f7c50
          Log:
          Fix JENKINS-18889

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: pom.xml src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java http://jenkins-ci.org/commit/buildresult-trigger-plugin/e3e29b92c57f57a120cc0afa3a7da13b844f7c50 Log: Fix JENKINS-18889

            People

            • Assignee:
              gbois Gregory Boissinot
              Reporter:
              tparent Tony Parent
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: