Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18912

Token macro help text is duplicated many times

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When expanding the help sections in Editable Email notification or Conditional Run action, the sections for the Token Macro help text are duplicate many times. This makes the help almost unusable as there is a mass amount of scrolling that is required to figure out which options are available for use.

      Jenkins 1.510
      Token Macro 1.8
      Email Extension 2.30.2
      Run condition .10
      conditional-buildstep 1.3

        Attachments

          Activity

          Hide
          abarychev Andrei Barychev added a comment -

          As you can see in the screenshots, the private tokens are not present in cond-step's token list after Jenkins restart. They appear there only after I run a job.

          Show
          abarychev Andrei Barychev added a comment - As you can see in the screenshots, the private tokens are not present in cond-step's token list after Jenkins restart. They appear there only after I run a job.
          Hide
          slide_o_mix Alex Earl added a comment -

          Aha! I think I have a fix for this. I'll push the changes and post the URL for the build server so you can try a new hpi for token-macro.

          Show
          slide_o_mix Alex Earl added a comment - Aha! I think I have a fix for this. I'll push the changes and post the URL for the build server so you can try a new hpi for token-macro.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java
          http://jenkins-ci.org/commit/token-macro-plugin/95b946e160434368fb381031af1879d246520580
          Log:
          Fix JENKINS-18912

          Created new list to hold the macros instead of using that returned by all(). If we use the one returned by all(), then all the private macros get added to the ExtensionList for TokenMacro!

          Compare: https://github.com/jenkinsci/token-macro-plugin/compare/c08666135eb6...95b946e16043

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/TokenMacro.java http://jenkins-ci.org/commit/token-macro-plugin/95b946e160434368fb381031af1879d246520580 Log: Fix JENKINS-18912 Created new list to hold the macros instead of using that returned by all(). If we use the one returned by all(), then all the private macros get added to the ExtensionList for TokenMacro! Compare: https://github.com/jenkinsci/token-macro-plugin/compare/c08666135eb6...95b946e16043
          Show
          slide_o_mix Alex Earl added a comment - https://jenkins.ci.cloudbees.com/job/plugins/job/token-macro-plugin/lastBuild/org.jenkins-ci.plugins$token-macro/artifact/org.jenkins-ci.plugins/token-macro/1.9-SNAPSHOT/token-macro-1.9-SNAPSHOT.hpi
          Hide
          slide_o_mix Alex Earl added a comment -

          Made a new List<TokenMacro> so that the private tokens were not added to the ExtensionList<TokenMacro> each time.

          Show
          slide_o_mix Alex Earl added a comment - Made a new List<TokenMacro> so that the private tokens were not added to the ExtensionList<TokenMacro> each time.

            People

            • Assignee:
              slide_o_mix Alex Earl
              Reporter:
              walterk82 Walter Kacynski
            • Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: