Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19142

Don't add jobs to a view

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      On creating a new job while being in a view, the job will be added to this view. This doesn't neccesarily make sense, especially when using regular expressions to filter the jobs.

      There should be a flag "don't add job to view on creation" in the view or a similar mechanism to prevent this.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Vincent Latombe
            Path:
            core/src/main/java/hudson/model/ListView.java
            core/src/main/resources/hudson/model/ListView/newJobButtonBar.jelly
            core/src/main/resources/hudson/model/View/newJob.jelly
            core/src/main/resources/hudson/model/View/newJobButtonBar.jelly
            war/src/main/js/widgets/add/addform.less
            http://jenkins-ci.org/commit/jenkins/f4c9eb0322f44d1f6b025a509fcae5a704bde666
            Log:
            JENKINS-19142 Prompt user whether to add the job to the current view (#2529)

            • JENKINS-37857 Prompt user whether to add the job to the current view
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vincent Latombe Path: core/src/main/java/hudson/model/ListView.java core/src/main/resources/hudson/model/ListView/newJobButtonBar.jelly core/src/main/resources/hudson/model/View/newJob.jelly core/src/main/resources/hudson/model/View/newJobButtonBar.jelly war/src/main/js/widgets/add/addform.less http://jenkins-ci.org/commit/jenkins/f4c9eb0322f44d1f6b025a509fcae5a704bde666 Log: JENKINS-19142 Prompt user whether to add the job to the current view (#2529) JENKINS-37857 Prompt user whether to add the job to the current view JENKINS-37857 Fix review items from @daniel-beck
            Hide
            vlatombe Vincent Latombe added a comment -

            Fixed in 2.22

            Show
            vlatombe Vincent Latombe added a comment - Fixed in 2.22
            Hide
            alexellisadp Alex Ellis added a comment -

            Causes regression in createItem by view in Jenkins 2.0 and onwards. Please consider reverting changes or making the code which expects a form submission optional, not mandatory. See related bug notes for more details.

            Show
            alexellisadp Alex Ellis added a comment - Causes regression in createItem by view in Jenkins 2.0 and onwards. Please consider reverting changes or making the code which expects a form submission optional, not mandatory. See related bug notes for more details.
            Hide
            vlatombe Vincent Latombe added a comment -

            Please don't reopen this issue because it caused a regression. There is already JENKINS-41128 opened to track the problem.

            Show
            vlatombe Vincent Latombe added a comment - Please don't reopen this issue because it caused a regression. There is already JENKINS-41128 opened to track the problem.
            Hide
            alexellisadp Alex Ellis added a comment - - edited

            Technically the code contributed for this fix will have to change to accommodate the breakage. So it may need to be re-opened for re-testing. Also does it make sense to request a regression test from the original fixer? Does the project have any regression tests on top of the unit tests?

            Show
            alexellisadp Alex Ellis added a comment - - edited Technically the code contributed for this fix will have to change to accommodate the breakage. So it may need to be re-opened for re-testing. Also does it make sense to request a regression test from the original fixer? Does the project have any regression tests on top of the unit tests?

              People

              • Assignee:
                vlatombe Vincent Latombe
                Reporter:
                sbreitbach Steffen Breitbach
              • Votes:
                2 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: